[reinersteib+gmane@imap.cc: tool bar icons not updated according to :active condition]

From: Richard Stallman <rms@gnu.org>
Subject: [reinersteib+gmane@imap.cc: tool bar icons not updated according to :active condition]
Date: Wed, 01 Feb 2006 23:15:54 -0500	[thread overview]
Message-ID: <E1F4Vsw-0005b6-6l@fencepost.gnu.org> (raw)

Could someone please look at this problem, then respond?

------- Start of forwarded message -------
Mail-Followup-To: emacs-devel@gnu.org
To: emacs-devel@gnu.org
From: Reiner Steib <reinersteib+gmane@imap.cc>
Date: Mon, 23 Jan 2006 19:59:13 +0100
Organization: Dept. of Theoretical Physics, University of Ulm
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mail-Copies-To: nobody
Subject: tool bar icons not updated according to :active condition
Reply-To: Reiner Steib <Reiner.Steib@gmx.de>
X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63

Hi,

`gnus-group-mode-map' contains the following menu entry (see
`gnus-group-make-menu-bar'):

  (easy-menu-define gnus-group-reading-menu gnus-group-mode-map ""
    `("Group"
      [...]
      ["Describe" gnus-group-describe-group
        :active (gnus-group-group-name) ...]

I.e. this menu item should be inactive[1] if the point isn't on a
group line (e.g. on non-group lines when using topics mode [2]).  In
the menu, this works correctly, i.e. the menu item is disabled
(probably because the menu is updated when clicking on "Group").

In `gnus-group-make-tool-bar' the describe-group entry is also added
to the tool bar (icon: etc/images/gnus/describe-group.xpm):

  (tool-bar-add-item-from-menu
    'gnus-group-describe-group "describe-group" gnus-group-mode-map)

But after moving up/down in the group buffer (C-p/C-n), the icon is
not updated (enabled/disabled) when changing from a group to a topic
line and vice versa.

After `C-l' (or after `redraw-frame' [3]), the correct icon is
displayed.  A workaround could be to redraw the frame after every
point-motion (is there a after-point-motion-hook?).

Bye, Reiner.

[1]
,----[ <f1> f gnus-group-group-name RET ]
| gnus-group-group-name is a compiled Lisp function in `gnus-group.el'.
| (gnus-group-group-name)
| 
| Get the name of the newsgroup on the current line.
`----

[2]
,----
| [ Gnus -- 6456 ]
|   [ misc -- 11 ]
|          1: nnml:test 
|         10: nndraft:drafts 
| [...]
`----

[3] Tested with...

(global-set-key (kbd "<down>")
		(lambda (&optional arg)
		  (interactive)
		  (or arg (setq arg 1))
		  (next-line arg)
		  (redraw-frame (selected-frame))))
- -- 
       ,,,
      (o o)
- ---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
------- End of forwarded message -------