Setting key bindings in view-mode-hook

Setting key bindings in view-mode-hook

[Bill Wohler]

I'd like to bind "q" in `view-mode' to `View-kill-and-leave'.

I customized view-mode-hook with

  (lambda nil (local-set-key "q" (quote View-kill-and-leave)))

However, "C-h c q" in a buffer in view mode still shows View-quit.

What gives? How come my setting isn't honored?

This is in recent CVS snapshot of Emacs 22, but a quick check reveals
that this Emacs 21 shows the same behavior.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

RE: Setting key bindings in view-mode-hook

[Drew Adams]

    I'd like to bind "q" in `view-mode' to `View-kill-and-leave'.
    I customized view-mode-hook with

      (lambda nil (local-set-key "q" (quote View-kill-and-leave)))

    However, "C-h c q" in a buffer in view mode still shows View-quit.
    What gives? How come my setting isn't honored?
    This is in recent CVS snapshot of Emacs 22, but a quick check reveals
    that this Emacs 21 shows the same behavior.

It might help (I don't know) to look at my messages of 9/8/2005 and
9/9/2005, subject "quitting help buffer" (which are really about quitting
view-mode).

Re: Setting key bindings in view-mode-hook

[Bill Wohler]

"Drew Adams" <drew.adams@oracle.com> writes:

>     I'd like to bind "q" in `view-mode' to `View-kill-and-leave'.
>     I customized view-mode-hook with
>
>       (lambda nil (local-set-key "q" (quote View-kill-and-leave)))
>
>     However, "C-h c q" in a buffer in view mode still shows View-quit.
>     What gives? How come my setting isn't honored?
>     This is in recent CVS snapshot of Emacs 22, but a quick check reveals
>     that this Emacs 21 shows the same behavior.
>
> It might help (I don't know) to look at my messages of 9/8/2005 and
> 9/9/2005, subject "quitting help buffer" (which are really about quitting
> view-mode).

Thanks. It helps since misery loves company.

> But that is not the behavior I get. For me, it iconifies the frame. And, in
> some (rarer) cases, it leaves the frame displayed (no change): `q' does
> nothing at all in those cases.

I'm not using frames. However, I tried view-file-other-frame and hit
`q'. I expected either the buffer or the frame to go away, but as you
said, it was iconified instead. Ew.

At best, I'd like `q' to kill the *Help* buffer or buffer in
view-mode. At worst, I'd like to bury it. But for me, `q' either does
nothing (maybe after visiting the *Help* buffer), or closes the window
but leaves the *Help* buffer in the #2 spot so a subsequent C-x b
takes me not to the mh-e.texi file that I was expecting but to *Help*.

I find that the use of `C' reliably does what I want (as well as C-x
k, of course). However, my fingers really prefer `q'. I think it's a
bug that I can't bind `q' to View-kill-and-leave.

I agree with you that all those ways of quitting view-mode are silly.
Once you're in view-mode, how you got there is immaterial. I want `q'
to do the same thing whether I ran view-mode manually, whether I'm in
a *Help* buffer, whether I ran `v' from dired, or have view-read-only
turned on. KISS. Perhaps you and I need to come up with recipes that
reliably show what we mean, but I would argue that if the exit path
were more simple, we wouldn't be here in the first place. Rather than
try to find and isolate a small bug, we should redesign and simplify
the exit path.

For example, I think view-mode should take the same design as
customize, in which there is a single function to exit
(Custom-buffer-done), bound to `q', which buries the buffer, unless
the option custom-buffer-done-kill is turned on, in which case the
buffer is killed.

However, I would agree that now is not the time to do this.

My 2c anyway.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

Re: Setting key bindings in view-mode-hook

[Richard M. Stallman]

    I customized view-mode-hook with

      (lambda nil (local-set-key "q" (quote View-kill-and-leave)))

    However, "C-h c q" in a buffer in view mode still shows View-quit.

You need to bind it in the View mode keymap.
Do C-h b and you will see what I mean.

Re: Setting key bindings in view-mode-hook

[Bill Wohler]

Richard M. Stallman <rms@gnu.org> wrote:

>     I customized view-mode-hook with
> 
>       (lambda nil (local-set-key "q" (quote View-kill-and-leave)))
> 
>     However, "C-h c q" in a buffer in view mode still shows View-quit.
> 
> You need to bind it in the View mode keymap.
> Do C-h b and you will see what I mean.

Thanks. I was under the impression that local-set-key in a foo-mode-hook
DTRT. Does it not work in this case because view-mode is a minor mode?

Is this what you mean? It does the trick.

  (define-key view-mode-map "q" 'View-kill-and-leave)

Would you recommend adding this to:

- top-level in .emacs

- view-mode-hook

- (eval-after-load "view-mode")

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

Re: Setting key bindings in view-mode-hook

[Richard M. Stallman]

    Would you recommend adding this to:

    - top-level in .emacs

Won't work.

    - view-mode-hook

    - (eval-after-load "view-mode")

Those will work.

RE: Setting key bindings in view-mode-hook

[Drew Adams]

FYI - I just filed a bug for this.  Users should not have to customize Emacs
just to get a view-mode window to go away. This is a very annoying new
"feature".

`q' should not just do nothing; it should delete the frame if it is
one-window-p and it is not the sole frame. Or, at least, it should delete
the window (my delete-window will then delete a one-window frame). That is,
behavior like this should be the default behavior - quitting view mode
should get rid of the window, by default.

Re: Setting key bindings in view-mode-hook

[Johan Bockgård]

Bill Wohler <wohler@newt.com> writes:

> I'd like to bind "q" in `view-mode' to `View-kill-and-leave'.
>
> I customized view-mode-hook with
>
>   (lambda nil (local-set-key "q" (quote View-kill-and-leave)))

,----
| local-set-key is an interactive compiled Lisp function in `subr'.
| (local-set-key KEY COMMAND)
| 
| Give KEY a local binding as COMMAND.
| [...]
| The binding goes in the current buffer's local map, which in most
| cases is shared with all other buffers in the same major mode.
`----

Define the key in `view-mode-map' instead.

> However, "C-h c q" in a buffer in view mode still shows View-quit.

View mode is a minor mode. Minor mode maps take precedence over the
local map (where "q" will have been defined).

-- 
Johan Bockgård

Setting key bindings in view-mode-hook

[Bill Wohler]

I'd like to bind "q" in `view-mode' to `View-kill-and-leave'.

I customized view-mode-hook with

  (lambda nil (local-set-key "q" (quote View-kill-and-leave)))

However, "C-h c q" in a buffer in view mode still shows View-quit.

What gives? How come my setting isn't honored?

This is in recent CVS snapshot of Emacs 22, but a quick check reveals
that this Emacs 21 shows the same behavior.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.