From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: customizing `frame-background-mode' Date: Sun, 20 Nov 2005 18:22:22 -0500 Message-ID: References: <437DB290.8060203@gmx.at> <871x1cujjj.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1132529104 11107 80.91.229.2 (20 Nov 2005 23:25:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 20 Nov 2005 23:25:04 +0000 (UTC) Cc: rudalics@gmx.at, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 21 00:24:54 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EdyX6-0007Uz-An for ged-emacs-devel@m.gmane.org; Mon, 21 Nov 2005 00:23:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EdyX5-00081j-Jw for ged-emacs-devel@m.gmane.org; Sun, 20 Nov 2005 18:23:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EdyVt-0007ZX-Ch for emacs-devel@gnu.org; Sun, 20 Nov 2005 18:22:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EdyVs-0007ZE-Ku for emacs-devel@gnu.org; Sun, 20 Nov 2005 18:22:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EdyVs-0007ZA-BV for emacs-devel@gnu.org; Sun, 20 Nov 2005 18:22:24 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EdyVs-0001a2-Fd for emacs-devel@gnu.org; Sun, 20 Nov 2005 18:22:24 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1EdyVq-0001lA-Vb; Sun, 20 Nov 2005 18:22:23 -0500 Original-To: Juri Linkov In-reply-to: <871x1cujjj.fsf@jurta.org> (message from Juri Linkov on Sun, 20 Nov 2005 03:23:23 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46373 Archived-At: With other words, why not replace :type '(choice (choice-item dark) (choice-item light) (choice-item :tag "default" nil))) by :type '(choice (const dark) (const light) (const :tag "default" nil))) I think you are right. Changing "default" to "automatic" also seems like an improvement. So here's what I propose to install. Anyone see any problem with this patch? *** faces.el 18 Nov 2005 12:03:25 -0500 1.343 --- faces.el 20 Nov 2005 10:26:25 -0500 *************** *** 1591,1599 **** (set-default var value) (mapc 'frame-set-background-mode (frame-list))) :initialize 'custom-initialize-changed ! :type '(choice (choice-item dark) ! (choice-item light) ! (choice-item :tag "default" nil))) (defvar default-frame-background-mode nil "Internal variable for the default brightness of the background. --- 1591,1599 ---- (set-default var value) (mapc 'frame-set-background-mode (frame-list))) :initialize 'custom-initialize-changed ! :type '(choice (const dark) ! (const light) ! (const :tag "automatic" nil))) (defvar default-frame-background-mode nil "Internal variable for the default brightness of the background.