From: "Richard M. Stallman" <rms@gnu.org>
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: customizing `frame-background-mode'
Date: Sun, 20 Nov 2005 18:22:22 -0500 [thread overview]
Message-ID: <E1EdyVq-0001lA-Vb@fencepost.gnu.org> (raw)
In-Reply-To: <871x1cujjj.fsf@jurta.org> (message from Juri Linkov on Sun, 20 Nov 2005 03:23:23 +0200)
With other words, why not replace
:type '(choice (choice-item dark)
(choice-item light)
(choice-item :tag "default" nil)))
by
:type '(choice (const dark)
(const light)
(const :tag "default" nil)))
I think you are right. Changing "default" to "automatic"
also seems like an improvement. So here's what I propose to install.
Anyone see any problem with this patch?
*** faces.el 18 Nov 2005 12:03:25 -0500 1.343
--- faces.el 20 Nov 2005 10:26:25 -0500
***************
*** 1591,1599 ****
(set-default var value)
(mapc 'frame-set-background-mode (frame-list)))
:initialize 'custom-initialize-changed
! :type '(choice (choice-item dark)
! (choice-item light)
! (choice-item :tag "default" nil)))
(defvar default-frame-background-mode nil
"Internal variable for the default brightness of the background.
--- 1591,1599 ----
(set-default var value)
(mapc 'frame-set-background-mode (frame-list)))
:initialize 'custom-initialize-changed
! :type '(choice (const dark)
! (const light)
! (const :tag "automatic" nil)))
(defvar default-frame-background-mode nil
"Internal variable for the default brightness of the background.
prev parent reply other threads:[~2005-11-20 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 10:53 customizing `frame-background-mode' martin rudalics
2005-11-20 1:23 ` Juri Linkov
2005-11-20 9:47 ` martin rudalics
2005-11-20 21:47 ` Juri Linkov
2005-11-20 23:22 ` Richard M. Stallman
2005-11-20 23:22 ` Richard M. Stallman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1EdyVq-0001lA-Vb@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.