From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Potential GC-related problems in compose_chars_in_text Date: Wed, 14 Sep 2005 16:29:16 +0900 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1126683171 7154 80.91.229.2 (14 Sep 2005 07:32:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 14 Sep 2005 07:32:51 +0000 (UTC) Cc: emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 14 09:32:44 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EFRky-0005Sg-IL for ged-emacs-devel@m.gmane.org; Wed, 14 Sep 2005 09:32:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EFRj7-0003lg-1F for ged-emacs-devel@m.gmane.org; Wed, 14 Sep 2005 03:30:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EFRi7-0003ia-T0 for emacs-devel@gnu.org; Wed, 14 Sep 2005 03:29:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EFRi2-0003g8-Gx for emacs-devel@gnu.org; Wed, 14 Sep 2005 03:29:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EFRi2-0003ft-A8 for emacs-devel@gnu.org; Wed, 14 Sep 2005 03:29:34 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1EFRhz-0007CN-Ml; Wed, 14 Sep 2005 03:29:32 -0400 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.13.4/8.13.4/Debian-3) with ESMTP id j8E7TIT1001740; Wed, 14 Sep 2005 16:29:18 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.13.4/8.13.4/Debian-3) with ESMTP id j8E7TI4r026884; Wed, 14 Sep 2005 16:29:18 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1EFRhk-0005Xy-00; Wed, 14 Sep 2005 16:29:16 +0900 Original-To: rms@gnu.org In-reply-to: (rms@gnu.org) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42911 Archived-At: In article , "Richard M. Stallman" writes: > I think that the cleanest thing to do, in loops that don't need to be > as fast as possible, is avoid saving addresses of string data at all. I agree. But, I think display_mode_element is the place that have to be as fast as possible. > I think you are right about the bug, but I think your patch does not > completely fix it. Yes. As I wrote, the original patch I mailed was not complete. So, I installed a new one. Have you seen that change? Does it still need a fix? > I suspect that compose_chars_in_text does not need to be as fast as > possible. Handa, do you think it does? As I wrote, that function is not used anymore, thus I deleted it. --- Kenichi Handa handa@m17n.org