all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Richard M. Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Custom/define-minor-mode problem
Date: Tue, 23 Aug 2005 20:10:00 -0400	[thread overview]
Message-ID: <E1E7iq8-00064Y-H2@fencepost.gnu.org> (raw)
In-Reply-To: <20050822182030.28436.qmail@web60318.mail.yahoo.com> (message from Michael Mauger on Mon, 22 Aug 2005 11:20:30 -0700 (PDT))

    There was no feedback on this.  The problem could arise with any minor
    mode that has customized variables.  If no one objects, could it be
    comitted? 

I can't access the repository now, but it looks like you want to revert
the following change:

2005-06-26  Stefan Monnier  <monnier@iro.umontreal.ca>

	* emacs-lisp/easy-mmode.el (define-minor-mode): Don't automatically add
	a :require to the defcustom.

I don't remember the precise details of the bug that that change fixed,
but it certainly fixed one.  So your change is definitely not correct.
Please do not install it.

If there is a new bug to be corrected now, we can't address it properly
without considering the old problem at the same time.

  reply	other threads:[~2005-08-24  0:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-22 18:20 Custom/define-minor-mode problem Michael Mauger
2005-08-24  0:10 ` Richard M. Stallman [this message]
2005-08-24 11:33   ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2005-08-09 17:17 Michael Mauger
2005-08-10 17:45 ` Michael Mauger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1E7iq8-00064Y-H2@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.