From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: unnecessary fringe-indicators defcustom creates trouble Date: Sun, 31 Jul 2005 20:45:22 -0400 Message-ID: References: <200507290113.j6T1Drc18126@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1122858237 26529 80.91.229.2 (1 Aug 2005 01:03:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 1 Aug 2005 01:03:57 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 01 03:03:49 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DzOiV-0002zX-Ff for ged-emacs-devel@m.gmane.org; Mon, 01 Aug 2005 03:03:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DzOl8-0007yn-7a for ged-emacs-devel@m.gmane.org; Sun, 31 Jul 2005 21:06:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DzOgU-0005dm-JX for emacs-devel@gnu.org; Sun, 31 Jul 2005 21:01:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DzOgK-0005Yk-Fs for emacs-devel@gnu.org; Sun, 31 Jul 2005 21:01:28 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DzOgK-0005Qn-C2 for emacs-devel@gnu.org; Sun, 31 Jul 2005 21:01:28 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DzOdq-0005Eo-6H for emacs-devel@gnu.org; Sun, 31 Jul 2005 20:58:54 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DzOQk-0003tk-OJ; Sun, 31 Jul 2005 20:45:22 -0400 Original-To: Luc Teirlinck In-reply-to: <200507290113.j6T1Drc18126@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 28 Jul 2005 20:13:53 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41388 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41388 `indicate-empty-lines' is already a defcustomed variable (actually set in startup.el). `indicate-buffer-boundaries' is not, but it should be and the patches below make it customizable through startup.el. That sounds like a good idea. Your change in cus-start.el is a good one (assuming the details are right--I will take your word for that). Once this is done, there is no longer any need for the annoying fringe-indicators variable. The reason for this is to make it simple to request the usual options. This is the right thing for the menu bar. But I agree it shouldn't get in the way of setting the other variables directly, if you want to do that. So I propose this change. (I will also change the doc strings of default-indicate-empty-lines and default-indicate-buffer-boundaries.) *** fringe.el 10 Jul 2005 13:00:16 -0400 1.20 --- fringe.el 30 Jul 2005 20:30:12 -0400 *************** *** 269,298 **** "Set fringe indicators according to VALUE. This is usually invoked when setting `fringe-indicators' via customize." (setq fringe-indicators value) ! (setq default-indicate-empty-lines nil) ! (setq default-indicate-buffer-boundaries ! (cond ! ((memq value '(left right t)) ! value) ! ((eq value 'box) ! '((top . left) (bottom . right))) ! ((eq value 'mixed) ! '((top . left) (t . right))) ! ((eq value 'empty) ! (setq default-indicate-empty-lines t) ! nil) ! (t nil)))) ;;;###autoload (defcustom fringe-indicators nil "Visually indicate buffer boundaries and scrolling. ! Setting this variable, changes `default-indicate-buffer-boundaries'." :type '(choice (const :tag "No indicators" nil) (const :tag "On left" left) (const :tag "On right" right) (const :tag "Opposite, no arrows" box) (const :tag "Opposite, arrows right" mixed) ! (const :tag "Empty lines" empty)) :group 'fringe :require 'fringe :set 'set-fringe-indicators-1) --- 269,304 ---- "Set fringe indicators according to VALUE. This is usually invoked when setting `fringe-indicators' via customize." (setq fringe-indicators value) ! (unless (eq fringe-indicators 'other) ! (setq default-indicate-empty-lines nil) ! (setq default-indicate-buffer-boundaries ! (cond ! ((memq value '(left right t)) ! value) ! ((eq value 'box) ! '((top . left) (bottom . right))) ! ((eq value 'mixed) ! '((top . left) (t . right))) ! ((eq value 'empty) ! (setq default-indicate-empty-lines t) ! nil) ! (t nil))))) ;;;###autoload (defcustom fringe-indicators nil "Visually indicate buffer boundaries and scrolling. ! Setting this variable changes `default-indicate-buffer-boundaries' ! and `default-indicate-empty-lines'. ! The value `other' means don't set them at all; ! if you use that value, you can customize ! those individual variables directly." :type '(choice (const :tag "No indicators" nil) (const :tag "On left" left) (const :tag "On right" right) (const :tag "Opposite, no arrows" box) (const :tag "Opposite, arrows right" mixed) ! (const :tag "Empty lines" empty) ! (const :tag "Other" other)) :group 'fringe :require 'fringe :set 'set-fringe-indicators-1)