From: "Richard M. Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: unnecessary fringe-indicators defcustom creates trouble
Date: Sun, 31 Jul 2005 20:45:22 -0400 [thread overview]
Message-ID: <E1DzOQk-0003tk-OJ@fencepost.gnu.org> (raw)
In-Reply-To: <200507290113.j6T1Drc18126@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 28 Jul 2005 20:13:53 -0500 (CDT))
`indicate-empty-lines' is already a defcustomed variable (actually set
in startup.el). `indicate-buffer-boundaries' is not, but it should be
and the patches below make it customizable through startup.el.
That sounds like a good idea. Your change in cus-start.el is a good one
(assuming the details are right--I will take your word for that).
Once
this is done, there is no longer any need for the annoying
fringe-indicators variable.
The reason for this is to make it simple to request the usual options.
This is the right thing for the menu bar.
But I agree it shouldn't get in the way of setting the other variables
directly, if you want to do that. So I propose this change.
(I will also change the doc strings of default-indicate-empty-lines
and default-indicate-buffer-boundaries.)
*** fringe.el 10 Jul 2005 13:00:16 -0400 1.20
--- fringe.el 30 Jul 2005 20:30:12 -0400
***************
*** 269,298 ****
"Set fringe indicators according to VALUE.
This is usually invoked when setting `fringe-indicators' via customize."
(setq fringe-indicators value)
! (setq default-indicate-empty-lines nil)
! (setq default-indicate-buffer-boundaries
! (cond
! ((memq value '(left right t))
! value)
! ((eq value 'box)
! '((top . left) (bottom . right)))
! ((eq value 'mixed)
! '((top . left) (t . right)))
! ((eq value 'empty)
! (setq default-indicate-empty-lines t)
! nil)
! (t nil))))
;;;###autoload
(defcustom fringe-indicators nil
"Visually indicate buffer boundaries and scrolling.
! Setting this variable, changes `default-indicate-buffer-boundaries'."
:type '(choice (const :tag "No indicators" nil)
(const :tag "On left" left)
(const :tag "On right" right)
(const :tag "Opposite, no arrows" box)
(const :tag "Opposite, arrows right" mixed)
! (const :tag "Empty lines" empty))
:group 'fringe
:require 'fringe
:set 'set-fringe-indicators-1)
--- 269,304 ----
"Set fringe indicators according to VALUE.
This is usually invoked when setting `fringe-indicators' via customize."
(setq fringe-indicators value)
! (unless (eq fringe-indicators 'other)
! (setq default-indicate-empty-lines nil)
! (setq default-indicate-buffer-boundaries
! (cond
! ((memq value '(left right t))
! value)
! ((eq value 'box)
! '((top . left) (bottom . right)))
! ((eq value 'mixed)
! '((top . left) (t . right)))
! ((eq value 'empty)
! (setq default-indicate-empty-lines t)
! nil)
! (t nil)))))
;;;###autoload
(defcustom fringe-indicators nil
"Visually indicate buffer boundaries and scrolling.
! Setting this variable changes `default-indicate-buffer-boundaries'
! and `default-indicate-empty-lines'.
! The value `other' means don't set them at all;
! if you use that value, you can customize
! those individual variables directly."
:type '(choice (const :tag "No indicators" nil)
(const :tag "On left" left)
(const :tag "On right" right)
(const :tag "Opposite, no arrows" box)
(const :tag "Opposite, arrows right" mixed)
! (const :tag "Empty lines" empty)
! (const :tag "Other" other))
:group 'fringe
:require 'fringe
:set 'set-fringe-indicators-1)
next prev parent reply other threads:[~2005-08-01 0:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 1:13 unnecessary fringe-indicators defcustom creates trouble Luc Teirlinck
2005-07-29 15:29 ` Kim F. Storm
2005-07-30 4:02 ` Luc Teirlinck
2005-08-01 0:45 ` Richard M. Stallman [this message]
2005-08-01 2:47 ` Luc Teirlinck
2005-08-01 16:45 ` Richard M. Stallman
[not found] ` <200508012118.j71LI0N06793@raven.dms.auburn.edu>
2005-08-02 17:44 ` Richard M. Stallman
2005-08-02 20:31 ` Luc Teirlinck
2005-08-03 19:09 ` Richard M. Stallman
2005-08-04 1:03 ` Luc Teirlinck
2005-08-04 2:49 ` Luc Teirlinck
2005-08-06 18:36 ` Richard M. Stallman
2005-08-06 18:36 ` Richard M. Stallman
2005-08-01 4:04 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DzOQk-0003tk-OJ@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.