Code inspection: Generic problems

Code inspection: Generic problems

[Kim F. Storm]

I found that a number of global lisp objects which have no staticpro.

The following vars seems to need staticpro, but could someone
pls. check -- and add a comment if that is really ok:

- Qecho_area_clear_hook
- re_match_object

I assume that it is ok for window and buffer vars to not have
staticpro, but could someone pls. check these anyway:

- combine_after_change_buffer
- echo_area_window
- echo_message_buffer
- last_point_position_buffer
- last_undo_buffer
- minibuf_window
- selected_frame
- selected_window

The following is used in print -- which probably doesn't cons,
so it is ok.  Can someone check -- and add a comment:

- being_printed


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Code inspection: Generic problems

[Richard M. Stallman]

    - Qecho_area_clear_hook

I think that should be staticpro'd.  I will do it.

   - echo_area_window 
   - minibuf_window
    - selected_frame
    - selected_window

All the live windows and frames get marked thru that data structure.

    - echo_message_buffer

That buffer is one of the echo area buffers, and they
can't be killed.

    - combine_after_change_buffer

I will staticpro that one.

    - last_point_position_buffer

Nothing bad can happen if that points to a buffer that has been gc'd.

    - last_undo_buffer

Likewise.