From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: doctor.el Date: Sun, 03 Jul 2005 16:43:01 -0400 Message-ID: References: <92a5eb47050702155627ac4ec7@mail.gmail.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1120424427 16171 80.91.229.2 (3 Jul 2005 21:00:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2005 21:00:27 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 03 23:00:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DpBZG-0003MM-CW for ged-emacs-devel@m.gmane.org; Sun, 03 Jul 2005 22:59:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DpBaR-0007BJ-59 for ged-emacs-devel@m.gmane.org; Sun, 03 Jul 2005 17:01:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DpBVq-0004Sv-Gn for emacs-devel@gnu.org; Sun, 03 Jul 2005 16:56:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DpBVp-0004SK-GJ for emacs-devel@gnu.org; Sun, 03 Jul 2005 16:56:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DpBUn-0003kW-9G for emacs-devel@gnu.org; Sun, 03 Jul 2005 16:55:21 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DpBQW-0000RJ-3f for emacs-devel@gnu.org; Sun, 03 Jul 2005 16:50:56 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DpBIr-00026o-CA; Sun, 03 Jul 2005 16:43:01 -0400 Original-To: Joshua Varner In-reply-to: <92a5eb47050702155627ac4ec7@mail.gmail.com> (message from Joshua Varner on Sat, 2 Jul 2005 17:56:59 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40261 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40261 There are a number a variables that are made buffer local, that are unique to doctor.el should those be prefixed as well? On general principles it would be cleaner to do so. Another alternative is to defvar them without initial value, since that doesn't affect other files. On general principles, that is less clean, but it might be adequate, and it might be more convenient in other ways. When you mention the 'doctor specs' are you referring to the below: (defun doctor-meaning (x) (get x 'doctor-meaning)) (defmacro doctor-put-meaning (symb val) "Store the base meaning of a word on the property list." (list 'put (list 'quote symb) ''doctor-meaning val)) doctor-put is called on a bunch of global symbols, but the property is prefixed by 'doctor-', Yes. if these are the ones you want converted would it be better to not use properties at all, I looked at that, and it looks like the names defined with doctor-put-meaning have nothing to do with the issue. I was talking about the names that seem to be set up as local variables. That is what makes the warnings.