From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: url-retrieve bad handling of redirections Date: Fri, 01 Jul 2005 00:03:49 -0400 Message-ID: References: <42C06E8D.6090505@student.lu.se> <42C1A7AA.3000507@student.lu.se> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1120190549 10467 80.91.229.2 (1 Jul 2005 04:02:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 1 Jul 2005 04:02:29 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 01 06:02:20 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DoCjK-0006ST-Sf for ged-emacs-devel@m.gmane.org; Fri, 01 Jul 2005 06:02:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DoCri-0005nO-Bb for ged-emacs-devel@m.gmane.org; Fri, 01 Jul 2005 00:10:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DoCph-0004xv-FX for emacs-devel@gnu.org; Fri, 01 Jul 2005 00:08:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DoCpa-0004u8-IG for emacs-devel@gnu.org; Fri, 01 Jul 2005 00:08:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DoCpZ-0004sE-25 for emacs-devel@gnu.org; Fri, 01 Jul 2005 00:08:45 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DoCrZ-0003RX-Fj for emacs-devel@gnu.org; Fri, 01 Jul 2005 00:10:49 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DoCkn-0000kp-LF; Fri, 01 Jul 2005 00:03:49 -0400 Original-to: Lennart Borgman In-reply-to: (rms@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40002 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40002 Adding a new parameter to the callback routine so that it still can have the original outfile as a parameter. That way you could continue from the redirect and change the redirected url instead of the original. What do you think of this change? Unfortunately it is not practical for me to study the code enough to tell if this would break anything. *** url-http.el 28 Jun 2005 17:36:57 -0400 1.16 --- url-http.el 30 Jun 2005 20:59:56 -0400 *************** *** 501,508 **** (url-request-data url-http-data) (url-request-extra-headers url-http-extra-headers)) (url-retrieve redirect-uri url-callback-function ! (cons redirect-uri ! (cdr url-callback-arguments))) (url-mark-buffer-as-dead (current-buffer)))))) (4 ; Client error ;; 400 Bad Request --- 501,509 ---- (url-request-data url-http-data) (url-request-extra-headers url-http-extra-headers)) (url-retrieve redirect-uri url-callback-function ! (cons :redirect ! (cons redirect-uri ! url-callback-arguments))) (url-mark-buffer-as-dead (current-buffer)))))) (4 ; Client error ;; 400 Bad Request