all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Richard M. Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: url-retrieve bad handling of redirections
Date: Fri, 01 Jul 2005 00:03:49 -0400	[thread overview]
Message-ID: <E1DoCkn-0000kp-LF@fencepost.gnu.org> (raw)
In-Reply-To: <E1DnTjB-0006jo-NW@fencepost.gnu.org> (rms@gnu.org)

	Adding a new parameter to the callback routine so that it still can have 
	the original outfile as a parameter. That way you could continue from 
	the redirect and change the redirected url instead of the original.

What do you think of this change?
Unfortunately it is not practical for me to study the code enough
to tell if this would break anything.

*** url-http.el	28 Jun 2005 17:36:57 -0400	1.16
--- url-http.el	30 Jun 2005 20:59:56 -0400	
***************
*** 501,508 ****
  		 (url-request-data url-http-data)
  		 (url-request-extra-headers url-http-extra-headers))
  	     (url-retrieve redirect-uri url-callback-function
! 			   (cons redirect-uri
! 				 (cdr url-callback-arguments)))
  	     (url-mark-buffer-as-dead (current-buffer))))))
        (4				; Client error
         ;; 400 Bad Request
--- 501,509 ----
  		 (url-request-data url-http-data)
  		 (url-request-extra-headers url-http-extra-headers))
  	     (url-retrieve redirect-uri url-callback-function
! 			   (cons :redirect
! 				 (cons redirect-uri
! 				       url-callback-arguments)))
  	     (url-mark-buffer-as-dead (current-buffer))))))
        (4				; Client error
         ;; 400 Bad Request

           reply	other threads:[~2005-07-01  4:03 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <E1DnTjB-0006jo-NW@fencepost.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1DoCkn-0000kp-LF@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.