From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: foreground menu bug Date: Tue, 28 Jun 2005 00:16:57 -0400 Message-ID: References: <20050615.071604.11389732.wl@gnu.org> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1119933409 21110 80.91.229.2 (28 Jun 2005 04:36:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 28 Jun 2005 04:36:49 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 28 06:36:31 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dn7o6-0007kZ-Br for ged-emacs-devel@m.gmane.org; Tue, 28 Jun 2005 06:34:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dn7vs-0004p2-Bl for ged-emacs-devel@m.gmane.org; Tue, 28 Jun 2005 00:42:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dn7pL-0001VA-7v for emacs-devel@gnu.org; Tue, 28 Jun 2005 00:36:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dn7pG-0001T6-Gc for emacs-devel@gnu.org; Tue, 28 Jun 2005 00:35:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dn7pG-0001DS-9j for emacs-devel@gnu.org; Tue, 28 Jun 2005 00:35:58 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dn7cd-0004Vz-Eh for emacs-devel@gnu.org; Tue, 28 Jun 2005 00:22:55 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Dn7Wr-0000gw-90; Tue, 28 Jun 2005 00:16:57 -0400 Original-To: Mathias Dahl In-reply-to: (message from Mathias Dahl on Mon, 27 Jun 2005 10:22:15 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:39735 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39735 Also, what does a disabled menu item tell the user? He might not understand that it is because font lock is enabled. He might wonder if he is doing something wrong seeing that menu item disabled. This makes no sense. Menu items are disabled when they are not applicable; users know that. Assuming the user notices that we disabled the menu item, your fix might work. What about users who use M-x apropos or similar to find commands and then used enter the commands with M-x, how would they know that this comment is currently "disabled", or not meant to be used? It might be a good idea to do that in addition. What do you think of this patch? *** facemenu.el 27 Jun 2005 16:24:59 -0400 1.79 --- facemenu.el 27 Jun 2005 22:24:24 -0400 *************** *** 611,617 **** self-insert-face (list self-insert-face))) face) ! self-insert-face-command this-command))))) (defun facemenu-active-faces (face-list &optional frame) "Return from FACE-LIST those faces that would be used for display. --- 611,619 ---- self-insert-face (list self-insert-face))) face) ! self-insert-face-command this-command)))) ! (unless (facemenu-enable-faces-p) ! (message "Font-lock mode will override any faces you set in this buffer"))) (defun facemenu-active-faces (face-list &optional frame) "Return from FACE-LIST those faces that would be used for display.