From: "Richard M. Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: foreground menu bug
Date: Tue, 28 Jun 2005 00:16:57 -0400 [thread overview]
Message-ID: <E1Dn7Wr-0000gw-90@fencepost.gnu.org> (raw)
In-Reply-To: <uhdfk5hvs.fsf@gmail.com> (message from Mathias Dahl on Mon, 27 Jun 2005 10:22:15 +0200)
Also, what does a disabled menu item tell the user? He might not
understand that it is because font lock is enabled. He might wonder if
he is doing something wrong seeing that menu item disabled.
This makes no sense. Menu items are disabled when they are not
applicable; users know that.
Assuming the user notices that we disabled the menu item, your fix
might work. What about users who use M-x apropos or similar to find
commands and then used enter the commands with M-x, how would they
know that this comment is currently "disabled", or not meant to be
used?
It might be a good idea to do that in addition. What do you think
of this patch?
*** facemenu.el 27 Jun 2005 16:24:59 -0400 1.79
--- facemenu.el 27 Jun 2005 22:24:24 -0400
***************
*** 611,617 ****
self-insert-face
(list self-insert-face)))
face)
! self-insert-face-command this-command)))))
(defun facemenu-active-faces (face-list &optional frame)
"Return from FACE-LIST those faces that would be used for display.
--- 611,619 ----
self-insert-face
(list self-insert-face)))
face)
! self-insert-face-command this-command))))
! (unless (facemenu-enable-faces-p)
! (message "Font-lock mode will override any faces you set in this buffer")))
(defun facemenu-active-faces (face-list &optional frame)
"Return from FACE-LIST those faces that would be used for display.
next prev parent reply other threads:[~2005-06-28 4:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 5:16 foreground menu bug Werner LEMBERG
2005-06-15 13:28 ` Mathias Dahl
2005-06-16 4:07 ` Richard Stallman
2005-06-20 9:08 ` Lute Kamstra
2005-06-21 8:09 ` Mathias Dahl
2005-06-26 4:46 ` Richard M. Stallman
2005-06-26 10:30 ` Lute Kamstra
2005-06-26 22:42 ` Richard M. Stallman
2005-06-27 8:22 ` Mathias Dahl
2005-06-28 4:16 ` Richard M. Stallman [this message]
2005-06-28 8:18 ` Mathias Dahl
2005-06-16 11:51 ` Lute Kamstra
2005-06-17 4:38 ` Richard Stallman
2005-06-17 11:19 ` Lute Kamstra
2005-06-20 8:38 ` Lute Kamstra
2005-06-27 13:14 ` Werner LEMBERG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Dn7Wr-0000gw-90@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.