Bug in y-or-n-p?

Bug in y-or-n-p?

[Richard M. Stallman]

Can someone please debug this?

    From: "Drew Adams" <drew.adams@oracle.com>

    1. Define these:

    (defun foo () (y-or-n-p "foo? "))
    (defun bar () (y-or-n-p "bar? "))
    (setq kill-emacs-query-functions '(foo bar))

    2. Use the menu-bar File > Exit Emacs. 

    The question "foo? " correctly appears in a popup menu y/n.

    3. Respond `n'  to "foo? ".

    4. The question "bar? " should be asked via a popup menu also, but it
       appears instead in the minibuffer.

    That is, the user starts with the mouse and menu-bar, but he is
    obliged to switch mid-stream to answering with the keyboard.

I think something in the C code is setting last_nonmenu_event
in between the two calls to y-or-n-p.  Could someone please
find out what?

Re: Bug in y-or-n-p?

[Luc Teirlinck]

Richard Stallman wrote:
   
   Can someone please debug this?

       From: "Drew Adams" <drew.adams@oracle.com>

       1. Define these:

       (defun foo () (y-or-n-p "foo? "))
       (defun bar () (y-or-n-p "bar? "))
       (setq kill-emacs-query-functions '(foo bar))

       2. Use the menu-bar File > Exit Emacs. 

       The question "foo? " correctly appears in a popup menu y/n.

       3. Respond `n'  to "foo? ".

       4. The question "bar? " should be asked via a popup menu also, but it
	  appears instead in the minibuffer.

No, the question bar should not be asked at all if you answere `n' to
foo, and in today's CVS it is not asked, at least not on GNU/Linux.

If you answer `y' to foo, then bar should be asked via a popup menu,
and it is, in today's CVS, at least on GNU/Linux.

There is no bug.

>From the kill-emacs-query-functions docstring:

  Functions to call with no arguments to query about killing Emacs.
  If any of these functions returns nil, killing Emacs is cancelled. 

In other words, once you answer `n' to any question, the other
questions are not asked.  The fact that bar was asked for Drew could
have been a temporary bug In CVS which would appear to be fixed now.
Unless it is operating system specific, or a local problem with Drew's
setup.

Sincerely,

Luc.

RE: Bug in y-or-n-p?

[Drew Adams]

           1. Define these:
    
           (defun foo () (y-or-n-p "foo? "))
           (defun bar () (y-or-n-p "bar? "))
           (setq kill-emacs-query-functions '(foo bar))
    
           2. Use the menu-bar File > Exit Emacs. 
    
           The question "foo? " correctly appears in a popup menu y/n.
    
           3. Respond `n'  to "foo? ".
    
           4. The question "bar? " should be asked via a popup menu 
              also, but it appears instead in the minibuffer.
    
    No, the question bar should not be asked at all if you answere `n' to
    foo, and in today's CVS it is not asked, at least not on GNU/Linux.
    
    If you answer `y' to foo, then bar should be asked via a popup menu,
    and it is, in today's CVS, at least on GNU/Linux.
    
    There is no bug.
    
    >From the kill-emacs-query-functions docstring:
    
      Functions to call with no arguments to query about killing Emacs.
      If any of these functions returns nil, killing Emacs is cancelled. 
    
    In other words, once you answer `n' to any question, the other
    questions are not asked.  The fact that bar was asked for Drew could
    have been a temporary bug In CVS which would appear to be fixed now.
    Unless it is operating system specific, or a local problem with Drew's
    setup.

I'm sorry, I meant this for foo:

 (defun foo ()  (y-or-n-p "foo? ") t) ; always return `t'


I'm using this version of Emacs:

In GNU Emacs 22.0.50.2 (i386-mingw-nt5.1.2600)
 of 2005-04-16 on LAPTOP
Distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Re: Bug in y-or-n-p?

[Luc Teirlinck]

Drew Adams wrote:

   I'm sorry, I meant this for foo:

    (defun foo ()  (y-or-n-p "foo? ") t) ; always return `t'

After that, and following the rest of your recipe, bar gets asked via
a popup menu, in today's CVS, on GNU/Linux.

Sincerely,

Luc.

RE: Bug in y-or-n-p?

[Drew Adams]

        (defun foo ()  (y-or-n-p "foo? ") t) ; always return `t'

    After that, and following the rest of your recipe, bar gets asked via
    a popup menu, in today's CVS, on GNU/Linux.

Great, then it's fixed. Thanks.

In my (April 2005) version, foo gets asked via popup menu, but bar gets
asked via the minibuffer.

Re: Bug in y-or-n-p?

[Juanma Barranquero]

> Great, then it's fixed. Thanks.
> 
> In my (April 2005) version, foo gets asked via popup menu, but bar gets
> asked via the minibuffer.

I don't think it is fixed. You were testing on Windows, weren't you? I
see the same problem with MinGW and MSVC on today's CVS.

-- 
                    /L/e/k/t/u

RE: Bug in y-or-n-p?

[Drew Adams]

    > Great, then it's fixed. Thanks.
    > 
    > In my (April 2005) version, foo gets asked via popup menu, 
    > but bar gets asked via the minibuffer.
    
    I don't think it is fixed. You were testing on Windows, weren't you? I
    see the same problem with MinGW and MSVC on today's CVS.
    
Yes, I'm on Windows. Thanks for checking the bug.

Distributor [WAS: Bug in y-or-n-p?]

[Glenn Morris]

> In GNU Emacs 22.0.50.2 (i386-mingw-nt5.1.2600)
> of 2005-04-16 on LAPTOP
> Distributor `Microsoft Corp.', version 5.1.2600

<shudder>

On aesthetic and sanity-preserving grounds, how about the following
change to emacsbug.el?


*** emacsbug.el 23 Nov 2004 19:22:43 -0000 1.63
--- emacsbug.el 22 Jun 2005 17:28:21 -0000
***************
*** 130,136 ****
      (insert "In " (emacs-version) "\n")
      (if (fboundp 'x-server-vendor)
      (condition-case nil
!         (insert "Distributor `" (x-server-vendor) "', version "
                      (mapconcat 'number-to-string (x-server-version)
                      ".") "\n")
                        (error t)))
      (if (and system-configuration-options
--- 130,136 ----
      (insert "In " (emacs-version) "\n")
      (if (fboundp 'x-server-vendor)
      (condition-case nil
!         (insert "X server distributor `" (x-server-vendor) "', version "
                (mapconcat 'number-to-string (x-server-version) ".")
                "\n")
                  (error t)))
      (if (and system-configuration-options

Re: Distributor [WAS: Bug in y-or-n-p?]

[Richard M. Stallman]

    On aesthetic and sanity-preserving grounds, how about the following
    change to emacsbug.el?

Please install it.

Re: Bug in y-or-n-p?

[Luc Teirlinck]

>From my previous message:

	  3. Respond `n'  to "foo? ".

	  4. The question "bar? " should be asked via a popup menu also, but it
	     appears instead in the minibuffer.

   No, the question bar should not be asked at all if you answer `n' to
   foo, and in today's CVS it is not asked, at least not on GNU/Linux.

I should added that, after answering `n' to foo:

foo (y or n) n

appears in the minibuffer as a confirmation that you answered `n' to
foo and killing Emacs was cancelled.

Sincerely,

Luc.