From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: compile.el underlining
Date: Fri, 17 Jun 2005 22:20:59 -0400
Message-ID: <E1DjSx9-0003U3-EW@fencepost.gnu.org>
References: <E1DjIIo-0001ri-0e@fencepost.gnu.org>
	<jwvbr65j8k1.fsf-monnier+emacs@gnu.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1119061110 5695 80.91.229.2 (18 Jun 2005 02:18:30 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sat, 18 Jun 2005 02:18:30 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 18 04:18:29 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1DjSu9-0007fQ-3g
	for ged-emacs-devel@m.gmane.org; Sat, 18 Jun 2005 04:17:53 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1DjSzs-0000Ba-8A
	for ged-emacs-devel@m.gmane.org; Fri, 17 Jun 2005 22:23:48 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DjSyh-0008CV-5h
	for emacs-devel@gnu.org; Fri, 17 Jun 2005 22:22:35 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DjSyd-0008AW-Ei
	for emacs-devel@gnu.org; Fri, 17 Jun 2005 22:22:31 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DjSyd-00089l-7a
	for emacs-devel@gnu.org; Fri, 17 Jun 2005 22:22:31 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DjSza-00087Y-UF
	for emacs-devel@gnu.org; Fri, 17 Jun 2005 22:23:30 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1DjSx9-0003U3-EW; Fri, 17 Jun 2005 22:20:59 -0400
Original-To: Stefan Monnier <monnier@iro.umontreal.ca>
In-reply-to: <jwvbr65j8k1.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on Fri, 17 Jun 2005 11:41:26 -0400)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:39055
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39055

    Is there a reason you use

       '((default :inherit font-lock-warning-face)
	 (((supports :underline t)) :underline t))

    rather than

       '((default :inherit font-lock-warning-face)
	 (t :underline t))

    after all, if it's not supported the setting is harmless.

       '((t :inherit font-lock-warning-face :underline t))

I was thinking of the changes I recently made to the underline face.
If you know that those two would work equivalently, please change it.