all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* HAVE_PWD_H
@ 2005-04-21 13:02 David Robinow
  2005-04-22  2:43 ` HAVE_PWD_H David Hunter
  0 siblings, 1 reply; 3+ messages in thread
From: David Robinow @ 2005-04-21 13:02 UTC (permalink / raw)


Recent changes to fileio.c, editfns.c, etc. have broken the MS Windows
build.  Although nt/inc/pwd.h exists, configure.bat does not detect
it.
HAVE_PWD_H, of course, can be unconditionally defined but I'm not
sure exactly where to do it so I'm not including a patch.
 However, conditionalizing the   #include <pwd.h> doesn't seem right
to me, unless the use of  "struct passwd" is also conditionalized.  As
it is now, if pwd.h is not included, the code won't compile.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: HAVE_PWD_H
  2005-04-21 13:02 HAVE_PWD_H David Robinow
@ 2005-04-22  2:43 ` David Hunter
  2005-04-22 22:35   ` HAVE_PWD_H Thien-Thi Nguyen
  0 siblings, 1 reply; 3+ messages in thread
From: David Hunter @ 2005-04-22  2:43 UTC (permalink / raw)
  Cc: emacs-devel

David Robinow wrote:
> Recent changes to fileio.c, editfns.c, etc. have broken the MS Windows
> build.  Although nt/inc/pwd.h exists, configure.bat does not detect
> it.
> HAVE_PWD_H, of course, can be unconditionally defined but I'm not
> sure exactly where to do it so I'm not including a patch.
>  However, conditionalizing the   #include <pwd.h> doesn't seem right
> to me, unless the use of  "struct passwd" is also conditionalized.  As
> it is now, if pwd.h is not included, the code won't compile.

HAVE_*_H are #defined in ms-w32.h (and #undefined in config.nt for good karma).  This patch fixes the build.
-Dave

Index: nt/config.nt
===================================================================
RCS file: /cvsroot/emacs/emacs/nt/config.nt,v
retrieving revision 1.19
diff -u -r1.19 config.nt
--- nt/config.nt	1 Sep 2003 15:45:46 -0000	1.19
+++ nt/config.nt	22 Apr 2005 02:11:04 -0000
@@ -139,6 +139,7 @@
 #undef HAVE_TERMIOS_H
 #undef HAVE_LIMITS_H
 #undef HAVE_STRING_H
+#undef HAVE_PWD_H
 #undef STDC_HEADERS
 #undef TIME_WITH_SYS_TIME
 
Index: src/s/ms-w32.h
===================================================================
RCS file: /cvsroot/emacs/emacs/src/s/ms-w32.h,v
retrieving revision 1.31
diff -u -r1.31 ms-w32.h
--- src/s/ms-w32.h	15 Feb 2005 23:14:05 -0000	1.31
+++ src/s/ms-w32.h	22 Apr 2005 02:14:16 -0000
@@ -230,6 +230,7 @@
 #undef  HAVE_TERMIOS_H
 #define HAVE_LIMITS_H 1
 #define HAVE_STRING_H 1
+#define HAVE_PWD_H 1
 #define STDC_HEADERS 1
 #define TIME_WITH_SYS_TIME 1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: HAVE_PWD_H
  2005-04-22  2:43 ` HAVE_PWD_H David Hunter
@ 2005-04-22 22:35   ` Thien-Thi Nguyen
  0 siblings, 0 replies; 3+ messages in thread
From: Thien-Thi Nguyen @ 2005-04-22 22:35 UTC (permalink / raw)
  Cc: emacs-devel, drobinow

   From: David Hunter <hunterd42@comcast.net>
   Date: Thu, 21 Apr 2005 22:43:57 -0400

   [patch for:
    nt/config.nt
    src/s/ms-w32.h
   undefining and defining HAVE_PWD_H]

thanks, installed.

thi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-04-22 22:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-21 13:02 HAVE_PWD_H David Robinow
2005-04-22  2:43 ` HAVE_PWD_H David Hunter
2005-04-22 22:35   ` HAVE_PWD_H Thien-Thi Nguyen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.