browse-url

browse-url

[Hugh Lawson]

Debian sarge
Emacs 21.4.1

browse-url works fine if firefox is already running. 

But suppose firefox isn't running.

If I do 'M-x browse-url' and fill in the url, then firefox pops up for
a second and then disappears.  The same thing happens with links I
click on in Emacs.

I think I can imagine a shell script to deal with this, but surely
there is something alread in Emacs.

-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[David Kastrup]

Hugh Lawson <hlawson@triad.rr.com> writes:

> Debian sarge
> Emacs 21.4.1
>
> browse-url works fine if firefox is already running. 
>
> But suppose firefox isn't running.
>
> If I do 'M-x browse-url' and fill in the url, then firefox pops up for
> a second and then disappears.  The same thing happens with links I
> click on in Emacs.
>
> I think I can imagine a shell script to deal with this, but surely
> there is something alread in Emacs.

The definition of browse-url-generic in browse-url.el needs to get
replaced with:

(defun browse-url-generic (url &optional new-window)
  ;; new-window ignored
  "Ask the WWW browser defined by `browse-url-generic-program' to load URL.
Default to the URL around or before point.  A fresh copy of the
browser is started up in a new process with possible additional arguments
`browse-url-generic-args'.  This is appropriate for browsers which
don't offer a form of remote control."
  (interactive (browse-url-interactive-arg "URL: "))
  (if (not browse-url-generic-program)
    (error "No browser defined (`browse-url-generic-program')"))
  (apply 'call-process browse-url-generic-program nil
	 0 nil
	 (append browse-url-generic-args (list url))))


-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: browse-url

[nfreimann]

David Kastrup wrote:

>The definition of browse-url-generic in browse-url.el needs to get
>replaced with:
>
>  
>

In browse-url-generic:
.emacs:78:14:Warning: reference to free variable `browse-url-generic-args'

In end of data:
.emacs:86:1:Warning: the function `browse-url-interactive-arg' is not 
known to
    be defined.

Re: browse-url

[David Kastrup]

nfreimann <niels_freimann@yahoo.de> writes:

> David Kastrup wrote:
>
>>The definition of browse-url-generic in browse-url.el needs to get
>>replaced with:
>>
>>  
>>
>
> In browse-url-generic:
> .emacs:78:14:Warning: reference to free variable `browse-url-generic-args'
>
> In end of data:
> .emacs:86:1:Warning: the function `browse-url-interactive-arg' is not
> known to
>     be defined.

Perhaps it would work to replace the whole of browse-url.el with the
version from Emacs CVS.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: browse-url

[Hugh Lawson]

David Kastrup <dak@gnu.org> writes:

> Hugh Lawson <hlawson@triad.rr.com> writes:
> 
> > Debian sarge
> > Emacs 21.4.1
> >
> > browse-url works fine if firefox is already running. 
> >
> > But suppose firefox isn't running.
> >
> > If I do 'M-x browse-url' and fill in the url, then firefox pops up for
> > a second and then disappears.  The same thing happens with links I
> > click on in Emacs.
> >
> > I think I can imagine a shell script to deal with this, but surely
> > there is something alread in Emacs.
> 
> The definition of browse-url-generic in browse-url.el needs to get
> replaced with:
> 
> (defun browse-url-generic (url &optional new-window)
>   ;; new-window ignored
>   "Ask the WWW browser defined by `browse-url-generic-program' to load URL.
> Default to the URL around or before point.  A fresh copy of the
> browser is started up in a new process with possible additional arguments
> `browse-url-generic-args'.  This is appropriate for browsers which
> don't offer a form of remote control."
>   (interactive (browse-url-interactive-arg "URL: "))
>   (if (not browse-url-generic-program)
>     (error "No browser defined (`browse-url-generic-program')"))
>   (apply 'call-process browse-url-generic-program nil
> 	 0 nil
> 	 (append browse-url-generic-args (list url))))

Hello David,

I don't understand how this solves my problem.  If mozilla-firefox is open and running. all is well. If it isn't then there is a problem.


-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[David Kastrup]

Hugh Lawson <hlawson@triad.rr.com> writes:

> David Kastrup <dak@gnu.org> writes:
>
>> Hugh Lawson <hlawson@triad.rr.com> writes:
>> 
>> > Debian sarge
>> > Emacs 21.4.1
>> >
>> > browse-url works fine if firefox is already running. 
>> >
>> > But suppose firefox isn't running.
>> >
>> > If I do 'M-x browse-url' and fill in the url, then firefox pops up for
>> > a second and then disappears.  The same thing happens with links I
>> > click on in Emacs.
>> >
>> > I think I can imagine a shell script to deal with this, but surely
>> > there is something alread in Emacs.
>> 
>> The definition of browse-url-generic in browse-url.el needs to get
>> replaced with:
>> 
>> (defun browse-url-generic (url &optional new-window)
>>   ;; new-window ignored
>>   "Ask the WWW browser defined by `browse-url-generic-program' to load URL.
>> Default to the URL around or before point.  A fresh copy of the
>> browser is started up in a new process with possible additional arguments
>> `browse-url-generic-args'.  This is appropriate for browsers which
>> don't offer a form of remote control."
>>   (interactive (browse-url-interactive-arg "URL: "))
>>   (if (not browse-url-generic-program)
>>     (error "No browser defined (`browse-url-generic-program')"))
>>   (apply 'call-process browse-url-generic-program nil
>> 	 0 nil
>> 	 (append browse-url-generic-args (list url))))
>
>
> I don't understand how this solves my problem.  If mozilla-firefox
> is open and running. all is well. If it isn't then there is a
> problem.

Emacs has several possibilities to start processes.  Starting with
call-process and 0 as third argument detaches the process completely
from Emacs.

Starting the process with start-process, in contrast, leaves the
process associated with Emacs.  If the process detaches itself from
the tty, Emacs assumes that it is finished and kills the process
group.  This is what happens with new Firefoxes that try to escape the
Emacs tty.

This is why you need an Elisp function that will use call-process
instead of start-process for starting Firefox if it is supposed to
survive detaching.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: browse-url

[Hugh Lawson]

David Kastrup <dak@gnu.org> writes:

> Hugh Lawson <hlawson@triad.rr.com> writes:
> 
> > David Kastrup <dak@gnu.org> writes:
> >
> >> Hugh Lawson <hlawson@triad.rr.com> writes:
> >> 
> >> > Debian sarge
> >> > Emacs 21.4.1
> >> >
> >> > browse-url works fine if firefox is already running. 
> >> >
> >> > But suppose firefox isn't running.
> >> >
> >> > If I do 'M-x browse-url' and fill in the url, then firefox pops up for
> >> > a second and then disappears.  The same thing happens with links I
> >> > click on in Emacs.
> >> >
> >> > I think I can imagine a shell script to deal with this, but surely
> >> > there is something alread in Emacs.
> >> 
> >> The definition of browse-url-generic in browse-url.el needs to get
> >> replaced with:
> >> 
> >> (defun browse-url-generic (url &optional new-window)
> >>   ;; new-window ignored
> >>   "Ask the WWW browser defined by `browse-url-generic-program' to load URL.
> >> Default to the URL around or before point.  A fresh copy of the
> >> browser is started up in a new process with possible additional arguments
> >> `browse-url-generic-args'.  This is appropriate for browsers which
> >> don't offer a form of remote control."
> >>   (interactive (browse-url-interactive-arg "URL: "))
> >>   (if (not browse-url-generic-program)
> >>     (error "No browser defined (`browse-url-generic-program')"))
> >>   (apply 'call-process browse-url-generic-program nil
> >> 	 0 nil
> >> 	 (append browse-url-generic-args (list url))))
> >
> >
> > I don't understand how this solves my problem.  If mozilla-firefox
> > is open and running. all is well. If it isn't then there is a
> > problem.
> 
> Emacs has several possibilities to start processes.  Starting with
> call-process and 0 as third argument detaches the process completely
> from Emacs.
> 
> Starting the process with start-process, in contrast, leaves the
> process associated with Emacs.  If the process detaches itself from
> the tty, Emacs assumes that it is finished and kills the process
> group.  This is what happens with new Firefoxes that try to escape the
> Emacs tty.
> 
> This is why you need an Elisp function that will use call-process
> instead of start-process for starting Firefox if it is supposed to
> survive detaching.

Thanks for the explanation, David.  I had trouble making it work, so
as a trial, I added the following two functions to my ~/.emacs file. 

Please critique. I did this purely empirically, with no real
understanding.



(defun browse-url-firefox (url &optional new-window )
  ;;new-window ignored
"Ask the firefox browser to  load URL."
 (apply 'call-process "firefox" nil
         0 nil (list url)))


(setq browse-url-browser-function  'browse-url-firefox)

-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[David Kastrup]

Hugh Lawson <hlawson@triad.rr.com> writes:

> David Kastrup <dak@gnu.org> writes:
>
>> This is why you need an Elisp function that will use call-process
>> instead of start-process for starting Firefox if it is supposed to
>> survive detaching.
>
> Thanks for the explanation, David.  I had trouble making it work, so
>as a trial, I added the following two functions to my ~/.emacs file.
>
> Please critique. I did this purely empirically, with no real
> understanding.
>
>
>
> (defun browse-url-firefox (url &optional new-window )
>   ;;new-window ignored
> "Ask the firefox browser to  load URL."
>  (apply 'call-process "firefox" nil
>          0 nil (list url)))

Well, looks a bit more complicated than necessary.  It should be
sufficient to write something like

(defun browse-url-firefox (url &optional new-window)
  (call-process "firefox" nil 0 nil url))

However, this should be quite equivalent to what you wrote, so if you
are experiencing problems, you'll need to describe them in more detail
to make it possible to guess what might be amiss.  At least in my
opinion, what you wrote looks like it should work.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: browse-url

[Hugh Lawson]

David Kastrup <dak@gnu.org> writes:

> However, this should be quite equivalent to what you wrote, so if you
> are experiencing problems, you'll need to describe them in more detail
> to make it possible to guess what might be amiss.  At least in my
> opinion, what you wrote looks like it should work.

The function adapted from your example seems to work ok. I will just
stop unti l it presents difficulties.  Thank you for your help.


-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[Joe Corneli]

Both of these functions appear to require starting a new firefox. (??)


(defun browse-url-firefox (url &optional new-window )
  ;;new-window ignored
"Ask the firefox browser to  load URL."
 (apply 'call-process "firefox" nil
         0 nil (list url)))

;;;

(defun browse-url-firefox (url &optional new-window)
  (call-process "firefox" nil 0 nil url))

Re: browse-url

[Greg Novak]

* Joe Corneli <jcorneli@math.utexas.edu> wrote:
> Both of these functions appear to require starting a new firefox. (??)

By a cosmic coincidence I just put the following in my .emacs file,
which opens a page in a new tab using an existing Firefox.  

(defun browse-url-firefox (url &optional new-window)
  (shell-command (concat "/usr/local/firefox/mozilla-xremote-client \"openurl("
		 url
		 ",new-tab)\"")))

(setq browse-url-browser-function 'browse-url-firefox)

Greg

Re: browse-url

[Joe Corneli]

Well here's a version that works for me & that will either open a
new firefox or use an existing one.  I think I'll send a bug
report about the issue I was seeing doing this the "simple way".

(defun browse-url-firefox (url &optional new-window)
  (when (eq (shell-command
             (concat 
              "/sw/lib/firefox/mozilla-xremote-client \"openurl("
              url
              ")\"")) 2)
    (call-process "firefox" nil 0 nil url)))

Re: browse-url

[Hugh Lawson]

Greg Novak <novak@ucolick.org> writes:

> * Joe Corneli <jcorneli@math.utexas.edu> wrote:
> > Both of these functions appear to require starting a new firefox. (??)
> 
> By a cosmic coincidence I just put the following in my .emacs file,
> which opens a page in a new tab using an existing Firefox.  
> 
> (defun browse-url-firefox (url &optional new-window)
>   (shell-command (concat "/usr/local/firefox/mozilla-xremote-client \"openurl("
> 		 url
> 		 ",new-tab)\"")))
> 
> (setq browse-url-browser-function 'browse-url-firefox)

This works for me too, just as Greg says, after customizing for my
paths.  It works like this.

        here's an url www.linux.org

        Put point on url, and do 'M-x browse-url'

        This puts in minibuffer: "URL: http://www.linux.org"

        <enter> makes the url open in a new tab in firefox

        But if I just type in the minibuffer "www.linux.org", it
        doesn't work. I have to type in the full
        '"http://www.linux.org".


Thanks for all the help everybody.

-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[Hugh Lawson]

Joe Corneli <jcorneli@math.utexas.edu> writes:

> Both of these functions appear to require starting a new firefox. (??)
> 

#1 
> (defun browse-url-firefox (url &optional new-window )
>   ;;new-window ignored
> "Ask the firefox browser to  load URL."
>  (apply 'call-process "firefox" nil
>          0 nil (list url)))
> 
> ;;;
#2
> (defun browse-url-firefox (url &optional new-window)
>   (call-process "firefox" nil 0 nil url))


Perhaps they do not.  I just did:

'M-x browse-url' twice, inputting two different urls, and still have
just one instance of firefox visible on the screen.  I can display the
two different pages by clicking the navigation toolbar arrows.

Before trying these functions, I could find no way by setting emacs
variables to start firefox if it was not already running.

There's probably a way, but I didn't find it. :(


-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[Joe Corneli]

   Joe Corneli <jcorneli@math.utexas.edu> writes:

   > Both of these functions appear to require starting a new firefox. (??)
   > 

   #1 
   > (defun browse-url-firefox (url &optional new-window )
   >   ;;new-window ignored
   > "Ask the firefox browser to  load URL."
   >  (apply 'call-process "firefox" nil
   >          0 nil (list url)))
   > 
   > ;;;
   #2
   > (defun browse-url-firefox (url &optional new-window)
   >   (call-process "firefox" nil 0 nil url))


   Perhaps they do not.  I just did:

   'M-x browse-url' twice, inputting two different urls, and still have
   just one instance of firefox visible on the screen.  I can display the
   two different pages by clicking the navigation toolbar arrows.

   Before trying these functions, I could find no way by setting emacs
   variables to start firefox if it was not already running.

   There's probably a way, but I didn't find it. :(


Well, I don't know what's different out our environments, but for me,
evaluating

(progn (call-process "firefox" nil 0 nil "http://www.gnu.org")
       (call-process "firefox" nil 0 nil "http://www.google.com"))

gives me one firefox window browsing gnu.org, and one of those idiot
boxes that I hate telling me to choose a new user (i.e. if no firefox
window is open; if a window is open, 2 X idiot box).

Re: browse-url

[Hugh Lawson]

Joe Corneli <jcorneli@math.utexas.edu> writes:


> 
> Well, I don't know what's different out our environments, but for me,
> evaluating
> 
> (progn (call-process "firefox" nil 0 nil "http://www.gnu.org")
>        (call-process "firefox" nil 0 nil "http://www.google.com"))
> 
> gives me one firefox window browsing gnu.org, and one of those idiot
> boxes that I hate telling me to choose a new user (i.e. if no firefox
> window is open; if a window is open, 2 X idiot box).

For me, it first went to gnu.org, and then went to google, as expected.

I've got Debian sarge and firefox 1.0.1, as provided by Debian package
1.0.1.

-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[Hugh Lawson]

Hugh Lawson <hlawson@triad.rr.com> writes:

> Joe Corneli <jcorneli@math.utexas.edu> writes:
> 
> 
> > 
> > Well, I don't know what's different out our environments, but for me,
> > evaluating
> > 
> > (progn (call-process "firefox" nil 0 nil "http://www.gnu.org")
> >        (call-process "firefox" nil 0 nil "http://www.google.com"))
> > 
> > gives me one firefox window browsing gnu.org, and one of those idiot
> > boxes that I hate telling me to choose a new user (i.e. if no firefox
> > window is open; if a window is open, 2 X idiot box).
> 
> For me, it first went to gnu.org, and then went to google, as expected.
> 
> I've got Debian sarge and firefox 1.0.1, as provided by Debian package
> 1.0.1.

oops!   should be Debian package mozilla-firefox.


-- 
Hugh Lawson
hlawson@triad.rr.com

Re: browse-url

[Christian Lynbech]

>>>>> "Joe" == Joe Corneli <jcorneli@math.utexas.edu> writes:

Joe> Well, I don't know what's different out our environments, but for me,
Joe> evaluating

Joe> (progn (call-process "firefox" nil 0 nil "http://www.gnu.org")
Joe>        (call-process "firefox" nil 0 nil "http://www.google.com"))

Joe> gives me one firefox window browsing gnu.org, and one of those idiot
Joe> boxes that I hate telling me to choose a new user (i.e. if no firefox
Joe> window is open; if a window is open, 2 X idiot box).

It appears that Hugh Lawson is running Debian and here /usr/bin/firefox points
to a ~400 line script that presumably examines the current situation and does
the right thing. Possibly, when you call "firefox" you get directly to the
application executable which only works as desired the first time.


------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic@hal.com (Michael A. Petonic)

Re: browse-url

[Hugh Lawson]

Christian Lynbech <christian.lynbech@ericsson.com> writes:

> >>>>> "Joe" == Joe Corneli <jcorneli@math.utexas.edu> writes:
> 
> Joe> Well, I don't know what's different out our environments, but for me,
> Joe> evaluating
> 
> Joe> (progn (call-process "firefox" nil 0 nil "http://www.gnu.org")
> Joe>        (call-process "firefox" nil 0 nil "http://www.google.com"))
> 
> Joe> gives me one firefox window browsing gnu.org, and one of those idiot
> Joe> boxes that I hate telling me to choose a new user (i.e. if no firefox
> Joe> window is open; if a window is open, 2 X idiot box).
> 
> It appears that Hugh Lawson is running Debian and here /usr/bin/firefox points
> to a ~400 line script that presumably examines the current situation and does
> the right thing. Possibly, when you call "firefox" you get directly to the
> application executable which only works as desired the first time.


I'm running Debian sarge, but Joe's elisp function works fine on my
system.

-- 
Hugh Lawson
hlawson@triad.rr.com