Fontification of ChangeLog entries.

Fontification of ChangeLog entries.

[Lute Kamstra]

When a name in a parenthesized list of a ChangeLog entry contains
spaces, only the first word gets fontified.  See {lispref,man}/ChangeLog
for examples.  What about the following patch to fix this?

Lute.


Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.156
diff -u -r1.156 add-log.el
--- lisp/add-log.el	21 Mar 2005 14:37:35 -0000	1.156
+++ lisp/add-log.el	1 Apr 2005 15:16:05 -0000
@@ -1,7 +1,7 @@
 ;;; add-log.el --- change log maintenance commands for Emacs
 
-;; Copyright (C) 1985, 86, 88, 93, 94, 97, 98, 2000, 03, 2004
-;;           Free Software Foundation, Inc.
+;; Copyright (C) 1985, 1986, 1988, 1993, 1994, 1997, 1998, 2000, 2003,
+;;   2004, 2005 Free Software Foundation, Inc.
 
 ;; Maintainer: FSF
 ;; Keywords: tools
@@ -230,15 +230,15 @@
      ;; Possibly further names in a list:
      ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))
      ;; Possibly a parenthesized list of names:
-     ("\\= (\\([^() ,\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
+     ("\\= (\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
       nil nil (1 'change-log-list-face))
-     ("\\=, *\\([^() ,\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
+     ("\\=, *\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
       nil nil (1 'change-log-list-face)))
     ;;
     ;; Function or variable names.
-    ("^\t(\\([^() ,\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
+    ("^\t(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
      (1 'change-log-list-face)
-     ("\\=, *\\([^() ,\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" nil nil
+     ("\\=, *\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" nil nil
       (1 'change-log-list-face)))
     ;;
     ;; Conditionals.

Re: Fontification of ChangeLog entries.

[Richard Stallman]

    When a name in a parenthesized list of a ChangeLog entry contains
    spaces, only the first word gets fontified.  See {lispref,man}/ChangeLog
    for examples.  What about the following patch to fix this?

I agree with the idea of fontifying more than the first word.  The
main question is whether the change has unwanted side effects in other
cases.  The best way to find that out is by trying it.  If it works fine,
I am in favor of it.

Re: Fontification of ChangeLog entries.

[Lute Kamstra]

Richard Stallman <rms@gnu.org> writes:

>     When a name in a parenthesized list of a ChangeLog entry contains
>     spaces, only the first word gets fontified.  See {lispref,man}/ChangeLog
>     for examples.  What about the following patch to fix this?
>
> I agree with the idea of fontifying more than the first word.  The
> main question is whether the change has unwanted side effects in other
> cases.  The best way to find that out is by trying it.  If it works fine,
> I am in favor of it.

I've browsed a large number of Emacs' ChangeLog files and saw no
problems.  Shall I install the patch so that others will test it too?

Lute.

Re: Fontification of ChangeLog entries.

[Richard Stallman]

    I've browsed a large number of Emacs' ChangeLog files and saw no
    problems.  Shall I install the patch so that others will test it too?

Yes, please.