compile.el does not find errors in numeric filenames

compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

I have a CVS version of emacs (checked out somewhere last week).

I have a file with name like 10776.cc and compile.el does not
recognize the output as errors.
Then I changed the filename to a10776.cc and it worked

i think one of the regexp in compilation-error-regexp-alist-alist
is not setup correctly

could some help me out ?

Re: compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

i debugged the problem.

the regexp  was this
    (gnu
     "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
\\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
\\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
 *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"
     1 (2 . 5) (4 . 6) (7 . 8))

and i changed it to
    (gnu
     "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
\\([/.]*[[:alnum:]]:?[^ \t\n:]*\\|{standard input}\\): ?\
\\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
\\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
 *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"
     1 (2 . 5) (4 . 6) (7 . 8))


I am also copying a diff file
please try it out and comment on it

diff -Naur old/compile.el new/compile.el
--- old/compile.el      2005-02-04 11:18:41.148180000 +0530
+++ new/compile.el      2005-02-04 11:18:13.099444056 +0530
@@ -214,7 +214,7 @@
 
     (gnu
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
+\\([/.]*[[:alnum:]]:?[^ \t\n:]*\\|{standard input}\\): ?\
 \\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
 \\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\


On Fri, 4 Feb 2005 10:29:04 +0530, Rajsekar Manokaran
<rajsekar@gmail.com> wrote:
> I have a CVS version of emacs (checked out somewhere last week).
> 
> I have a file with name like 10776.cc and compile.el does not
> recognize the output as errors.
> Then I changed the filename to a10776.cc and it worked
> 
> i think one of the regexp in compilation-error-regexp-alist-alist
> is not setup correctly
> 
> could some help me out ?
>

Fwd: compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

Sending this mail again coz i have not got any reply and something
tells me i sent this message before having got the reply from the
listbot.



I have a CVS version of emacs (checked out somewhere last week).

I have a file with name like 10776.cc and compile.el does not
recognize the output as errors.
Then I changed the filename to a10776.cc and it worked

i think one of the regexp in compilation-error-regexp-alist-alist
is not setup correctly

could some help me out ?

Re: compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

i debugged the problem.

the regexp  was this
   (gnu
    "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
\\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
\\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
*\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"
    1 (2 . 5) (4 . 6) (7 . 8))

and i changed it to
   (gnu
    "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
\\([/.]*[[:alnum:]]:?[^ \t\n:]*\\|{standard input}\\): ?\
\\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
\\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
*\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"
    1 (2 . 5) (4 . 6) (7 . 8))

I am also copying a diff file
please try it out and comment on it

diff -Naur old/compile.el new/compile.el
--- old/compile.el      2005-02-04 11:18:41.148180000 +0530
+++ new/compile.el      2005-02-04 11:18:13.099444056 +0530
@@ -214,7 +214,7 @@

    (gnu
     "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
+\\([/.]*[[:alnum:]]:?[^ \t\n:]*\\|{standard input}\\): ?\
\\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
\\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\


On Sat, 5 Feb 2005 20:20:51 +0530, Rajsekar Manokaran
<rajsekar@gmail.com> wrote:
> Sending this mail again coz i have not got any reply and something
> tells me i sent this message before having got the reply from the
> listbot.
> 
> 
> I have a CVS version of emacs (checked out somewhere last week).
> 
> I have a file with name like 10776.cc and compile.el does not
> recognize the output as errors.
> Then I changed the filename to a10776.cc and it worked
> 
> i think one of the regexp in compilation-error-regexp-alist-alist
> is not setup correctly
> 
> could some help me out ?
>

Re: compile.el does not find errors in numeric filenames

[Richard Stallman]

If this fixes the problem, I would like it to be installed; but any
change in these regexps has a good chance of creating another problem.
So I would like a couple of people who are familiar with this code
(and with the range of error messages that we see) to look at the
change and see if they can spot a problem.  If they don't, then
let's install it.

Would those people please look at it?

Re: compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

I am just changing the character class [a-zA-Z] to [[:alnum:]].
I dont see how this can create problems, but I would rather leave it
to the experts in this area.

Could some tell me when/if this change gets committed to the cvs?


On Sun, 06 Feb 2005 07:42:12 -0500, Richard Stallman <rms@gnu.org> wrote:
> If this fixes the problem, I would like it to be installed; but any
> change in these regexps has a good chance of creating another problem.
> So I would like a couple of people who are familiar with this code
> (and with the range of error messages that we see) to look at the
> change and see if they can spot a problem.  If they don't, then
> let's install it.
> 
> Would those people please look at it?
>

Re: compile.el does not find errors in numeric filenames

[Andreas Schwab]

Rajsekar Manokaran <rajsekar@gmail.com> writes:

> I am just changing the character class [a-zA-Z] to [[:alnum:]].
> I dont see how this can create problems, but I would rather leave it
> to the experts in this area.

Have you verified that all the examples in etc/compilation.txt are still
highlighted correctly?  How about adding your test case to it?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

yeah, all the things in /etc/compilation.txt are fontified properly.
My test case would be

1776.cc:41: error: `func' undeclared (first use this function)

-
Rajsekar Manokaran
IIT Madras


On Sun, 06 Feb 2005 16:41:41 +0100, Andreas Schwab <schwab@suse.de> wrote:
> Rajsekar Manokaran <rajsekar@gmail.com> writes:
> 
> > I am just changing the character class [a-zA-Z] to [[:alnum:]].
> > I dont see how this can create problems, but I would rather leave it
> > to the experts in this area.
> 
> Have you verified that all the examples in etc/compilation.txt are still
> highlighted correctly?  How about adding your test case to it?
> 
> Andreas.
> 
> --
> Andreas Schwab, SuSE Labs, schwab@suse.de
> SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
>

Re: compile.el does not find errors in numeric filenames

[Rajsekar Manokaran]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

As stefan pointed out, my change adds some patterns that are not
expected to be fontified

eg. 

2:\comp\asdf\tr.cc

I have changed the regexp again and it now works fine with all the
lines in compilation.txt (plus a line i have added).

Here is the patch
please check it and comment/commit.




On Mon, 7 Feb 2005 00:42:04 +0530, Rajsekar Manokaran
<rajsekar@gmail.com> wrote:
> yeah, all the things in /etc/compilation.txt are fontified properly.
> My test case would be
> 
> 1776.cc:41: error: `func' undeclared (first use this function)
> 
> -
> Rajsekar Manokaran
> IIT Madras
> 
> 
> On Sun, 06 Feb 2005 16:41:41 +0100, Andreas Schwab <schwab@suse.de> wrote:
> > Rajsekar Manokaran <rajsekar@gmail.com> writes:
> >
> > > I am just changing the character class [a-zA-Z] to [[:alnum:]].
> > > I dont see how this can create problems, but I would rather leave it
> > > to the experts in this area.
> >
> > Have you verified that all the examples in etc/compilation.txt are still
> > highlighted correctly?  How about adding your test case to it?
> >
> > Andreas.
> >
> > --
> > Andreas Schwab, SuSE Labs, schwab@suse.de
> > SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> > Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> > "And now for something completely different."
> >
>

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 1541 bytes --]

Index: etc/compilation.txt
===================================================================
RCS file: /cvsroot/emacs/emacs/etc/compilation.txt,v
retrieving revision 1.8
diff -u -4 -r1.8 compilation.txt
--- etc/compilation.txt	22 Nov 2004 23:17:26 -0000	1.8
+++ etc/compilation.txt	6 Feb 2005 20:26:31 -0000
@@ -216,8 +216,9 @@
 jade:dbcommon.dsl:133:17:E: missing argument for function call
 G:/cygwin/dev/build-myproj.xml:54: Compiler Adapter 'javac' can't be found.
 file:G:/cygwin/dev/build-myproj.xml:54: Compiler Adapter 'javac' can't be found.
 {standard input}:27041: Warning: end of file not at end of a line; newline inserted
+1776.cc:41: error: `func' undeclared (first use this function)
 
 
 * Lucid Compiler, lcc 3.x
 
Index: lisp/progmodes/compile.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v
retrieving revision 1.345
diff -u -4 -r1.345 compile.el
--- lisp/progmodes/compile.el	29 Jan 2005 15:50:26 -0000	1.345
+++ lisp/progmodes/compile.el	6 Feb 2005 20:26:33 -0000
@@ -213,9 +213,9 @@
 \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil (3 . 4))
 
     (gnu
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
+\\([/.]*\\(?:[a-zA-Z]:\\)?[^ \t\n:]*\\|{standard input}\\): ?\
 \\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
 \\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
  *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: compile.el does not find errors in numeric filenames

[Andreas Schwab]

Rajsekar Manokaran <rajsekar@gmail.com> writes:

> As stefan pointed out, my change adds some patterns that are not
> expected to be fontified
>
> eg. 
>
> 2:\comp\asdf\tr.cc
>
> I have changed the regexp again and it now works fine with all the
> lines in compilation.txt (plus a line i have added).

I'm seeing that the ada example is now fontified differently.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: compile.el does not find errors in numeric filenames

[Richard Stallman]

    I'm seeing that the ada example is now fontified differently.

What is the change?  Is it an improvement, a disadvantage, a bug,
or what?

Re: compile.el does not find errors in numeric filenames

[Andreas Schwab]

Richard Stallman <rms@gnu.org> writes:

>     I'm seeing that the ada example is now fontified differently.
>
> What is the change?  Is it an improvement, a disadvantage, a bug,
> or what?

It's now marking the line number as if it were the file name.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: compile.el does not find errors in numeric filenames

[Rajsekar]

I think, ada lines should be properly fontified.
Could someone review this patch?

On more thing i notice is that 

files like 

../../C:/hello.cc are recognized as valid filenames by cvs version.  Is it
valid?  I have not touched upon that issue in my patch, but if that is
invalid, we can modify the regexp (again!!!).

Index: lisp/progmodes/compile.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v
retrieving revision 1.345
diff -u -4 -r1.345 compile.el
--- lisp/progmodes/compile.el	29 Jan 2005 15:50:26 -0000	1.345
+++ lisp/progmodes/compile.el	7 Feb 2005 14:14:41 -0000
@@ -213,9 +213,9 @@
 \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil (3 . 4))
 
     (gnu
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
+\\([/.]*\\(?:[a-zA-Z]:\\)?[^ \t\n:]*[^[:digit:]][^ \t\n:]*\\|{standard input}\\): ?\
 \\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
 \\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
  *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"


-- 
    Rajsekar Manokaran
    IIT Madras

Re: compile.el does not find errors in numeric filenames

[Eli Zaretskii]

> From: Rajsekar <rajsekar@cse.iitm.ernet.in>
> Date: Mon, 07 Feb 2005 20:07:20 +0530
> Cc: rms@gnu.org, emacs-devel@gnu.org
> 
> files like 
> 
> ../../C:/hello.cc are recognized as valid filenames by cvs version.  Is it
> valid?

On DOS/Windows filesystems, this file name is invalid.  On Unix and
GNU systems, it's valid, but users of such systems rarely if at all
use such file names.

Anyway, how could such a string wind up in the compilation buffer?
That is, is this a real problem?

Re: compile.el does not find errors in numeric filenames

[Rajsekar]

"Eli Zaretskii" <eliz@gnu.org> writes:

>
> Anyway, how could such a string wind up in the compilation buffer?
> That is, is this a real problem?

Thats right.  It is not an actual problem.  If there are no more mistakes
in the regexp, my patch can be committed.  I am sending the complete patch
against the current cvs.

--8<---------------cut here---------------start------------->8---
Index: etc/compilation.txt
===================================================================
RCS file: /cvsroot/emacs/emacs/etc/compilation.txt,v
retrieving revision 1.8
diff -u -4 -r1.8 compilation.txt
--- etc/compilation.txt	22 Nov 2004 23:17:26 -0000	1.8
+++ etc/compilation.txt	7 Feb 2005 21:06:23 -0000
@@ -216,8 +216,9 @@
 jade:dbcommon.dsl:133:17:E: missing argument for function call
 G:/cygwin/dev/build-myproj.xml:54: Compiler Adapter 'javac' can't be found.
 file:G:/cygwin/dev/build-myproj.xml:54: Compiler Adapter 'javac' can't be found.
 {standard input}:27041: Warning: end of file not at end of a line; newline inserted
+1776.cc:41: error: `func' undeclared (first use this function)
 
 
 * Lucid Compiler, lcc 3.x
 
Index: lisp/progmodes/compile.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v
retrieving revision 1.345
diff -u -4 -r1.345 compile.el
--- lisp/progmodes/compile.el	29 Jan 2005 15:50:26 -0000	1.345
+++ lisp/progmodes/compile.el	7 Feb 2005 21:06:31 -0000
@@ -213,9 +213,9 @@
 \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil (3 . 4))
 
     (gnu
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
+\\([/.]*\\(?:[a-zA-Z]:\\)?[^ \t\n:]*[^[:digit:]][^ \t\n:]*\\|{standard input}\\): ?\
 \\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
 \\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
  *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\)\\)?"
--8<---------------cut here---------------end--------------->8---


-- 
    Rajsekar Manokaran
    IIT Madras

Re: compile.el does not find errors in numeric filenames

[Richard Stallman]

    files like 

    ../../C:/hello.cc are recognized as valid filenames by cvs version.  Is it
    valid?

That is a valid file name on GNU or Unix.  Perhaps on MS Windows it is
not.  However, if compile.el recognizes impossible file names if they
appear in an error message, that is not necessarily a problem.  It
only becomes a problem if this leads to incorrect parsing of error
messages that really occur.

Re: compile.el does not find errors in numeric filenames

[Rajsekar]

Richard Stallman <rms@gnu.org> writes:

>     files like 
>
>     ../../C:/hello.cc are recognized as valid filenames by cvs version.  Is it
>     valid?
>
> That is a valid file name on GNU or Unix.  Perhaps on MS Windows it is
> not.  However, if compile.el recognizes impossible file names if they
> appear in an error message, that is not necessarily a problem.  It
> only becomes a problem if this leads to incorrect parsing of error
> messages that really occur.
>

The patch does not seem to cause any problems in parsing/fontifying.  It
also makes sure numeric filenames (10231.cc) are fontifies+parsed
correctly.

Could someone commit it to the CVS?

-- 
    Rajsekar Manokaran
    IIT Madras

Re: compile.el does not find errors in numeric filenames

[Stefan Monnier]

> diff -Naur old/compile.el new/compile.el
> --- old/compile.el      2005-02-04 11:18:41.148180000 +0530
> +++ new/compile.el      2005-02-04 11:18:13.099444056 +0530
> @@ -214,7 +214,7 @@

>     (gnu
>      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
> -\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
> +\\([/.]*[[:alnum:]]:?[^ \t\n:]*\\|{standard input}\\): ?\
> \\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
> \\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
> \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\

Since the [a-zA-Z]:? is really mean to allow a ":" at the precise spot where
it tends to appear (after the drive letter in W32 paths), it might be better
to use \([a-zA-Z]:\)? so we don't allow drive letters to be digits or
accented chars.  But in the grand scheme of things, I think either way will
be fine.



        Stefan