all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Patch to
@ 2005-01-27 18:45 Francis Litterio
  2005-01-29  4:17 ` Richard Stallman
  0 siblings, 1 reply; 4+ messages in thread
From: Francis Litterio @ 2005-01-27 18:45 UTC (permalink / raw)


The below patch enables adaptive-fill-mode to properly fill paragraphs
that use 'o' as a bullet, like this:

  o  Testing one two three one two three one two three one two three one
     two three one two three one two three.

I hope this is considered useful.
--
Francis Litterio
franl <at> world . std . com


--- fill.el	20 Jul 2004 16:51:13 -0400	1.173
+++ fill.el	27 Jan 2005 13:45:06 -0500	
@@ -87,7 +87,7 @@
 (defcustom adaptive-fill-regexp
   ;; Added `!' for doxygen comments starting with `//!' or `/*!'.
   ;; Added `%' for TeX comments.
-  (purecopy "[ \t]*\\([-!|#%;>*]+[ \t]*\\|(?[0-9]+[.)][ \t]*\\)*")
+  (purecopy "[ \t]*\\([-!|#%;>*o]+[ \t]*\\|(?[0-9]+[.)][ \t]*\\)*")
   "*Regexp to match text at start of line that constitutes indentation.
 If Adaptive Fill mode is enabled, a prefix matching this pattern
 on the first and second lines of a paragraph is used as the

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Patch to
  2005-01-27 18:45 Patch to Francis Litterio
@ 2005-01-29  4:17 ` Richard Stallman
  2005-01-29 18:46   ` Stefan Monnier
  2005-01-30  1:21   ` Francis Litterio
  0 siblings, 2 replies; 4+ messages in thread
From: Richard Stallman @ 2005-01-29  4:17 UTC (permalink / raw)
  Cc: emacs-devel

    The below patch enables adaptive-fill-mode to properly fill paragraphs
    that use 'o' as a bullet, like this:

      o  Testing one two three one two three one two three one two three one
	 two three one two three one two three.

That result is an improvement, but I wonder if this might also
lead to false identification of prefixes in some cases.
I can't see, off hand, how that could happen, I just have
a concern about it.  Does anyone else see such cases?

If not, we can try it and see if it causes any problems.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Patch to
  2005-01-29  4:17 ` Richard Stallman
@ 2005-01-29 18:46   ` Stefan Monnier
  2005-01-30  1:21   ` Francis Litterio
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2005-01-29 18:46 UTC (permalink / raw)
  Cc: Francis Litterio, emacs-devel

> That result is an improvement, but I wonder if this might also
> lead to false identification of prefixes in some cases.
> I can't see, off hand, how that could happen, I just have
> a concern about it.  Does anyone else see such cases?

In Spanish, "o" means "or".


        Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Patch to
  2005-01-29  4:17 ` Richard Stallman
  2005-01-29 18:46   ` Stefan Monnier
@ 2005-01-30  1:21   ` Francis Litterio
  1 sibling, 0 replies; 4+ messages in thread
From: Francis Litterio @ 2005-01-30  1:21 UTC (permalink / raw)


Richard Stallman wrote:

>     The below patch enables adaptive-fill-mode to properly fill paragraphs
>     that use 'o' as a bullet, like this:
>
>       o  Testing one two three one two three one two three one two three one
> 	 two three one two three one two three.
>
> That result is an improvement, but I wonder if this might also
> lead to false identification of prefixes in some cases.
> I can't see, off hand, how that could happen, I just have
> a concern about it.  Does anyone else see such cases?
>
> If not, we can try it and see if it causes any problems.

I've found one case already where it causes a problem -- when filling a
long line that starts with a word beginning with 'o' or 'O', you end up
with a paragraph looking like this:

Of course, this is just a long line to demonstrate the problem.  Blah
 blah blah blah blah blah blah blah blah blah blah blah blah blah blah
 blah blah blah blah blah.

I think the regexp can be adjusted to compensate for this, but Stefan
Monnier's objection about "o" meaning "or" in Spanish is a much more
significant problem, and probably reason to leave this patch out.

Sorry for any confusion.
--
Francis Litterio
franl <at> world . std . com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-01-30  1:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-27 18:45 Patch to Francis Litterio
2005-01-29  4:17 ` Richard Stallman
2005-01-29 18:46   ` Stefan Monnier
2005-01-30  1:21   ` Francis Litterio

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.