From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: load-history is incorrect Date: Tue, 11 Jan 2005 09:29:46 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1105454535 20706 80.91.229.6 (11 Jan 2005 14:42:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Jan 2005 14:42:15 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 11 15:42:05 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CoNDh-000427-00 for ; Tue, 11 Jan 2005 15:42:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CoNPB-0000DI-RB for ged-emacs-devel@m.gmane.org; Tue, 11 Jan 2005 09:53:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CoNLI-0007SF-QH for emacs-devel@gnu.org; Tue, 11 Jan 2005 09:49:59 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CoNL8-0007LV-OV for emacs-devel@gnu.org; Tue, 11 Jan 2005 09:49:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CoNL5-0007J2-Tj for emacs-devel@gnu.org; Tue, 11 Jan 2005 09:49:43 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CoN29-0003rY-Mi for emacs-devel@gnu.org; Tue, 11 Jan 2005 09:30:09 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CoN1m-0000fw-2t; Tue, 11 Jan 2005 09:29:46 -0500 Original-To: "Drew Adams" In-reply-to: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:32120 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32120 In Emacs 20, each explicit `require' in a library is reflected in the entry for that library in variable `load-history'. In Emacs 21, the `load-history' seems to be seriously flawed (unless there is some change in the semantics that is not reflected by the doc string). Many explicit requires for a library are not listed in the library's entry in load-history. What do people think of this change? *** fns.c 27 Dec 2004 12:44:41 -0500 1.380 --- fns.c 10 Jan 2005 18:12:38 -0500 *************** *** 3443,3456 **** CHECK_SYMBOL (feature); tem = Fmemq (feature, Vfeatures); if (NILP (tem)) { int count = SPECPDL_INDEX (); int nesting = 0; - - LOADHIST_ATTACH (Fcons (Qrequire, feature)); /* This is to make sure that loadup.el gives a clear picture of what files are preloaded and when. */ --- 3443,3458 ---- CHECK_SYMBOL (feature); + /* Record the presence of `require' in this file + even if the feature specified is already loaded. */ + LOADHIST_ATTACH (Fcons (Qrequire, feature)); + tem = Fmemq (feature, Vfeatures); if (NILP (tem)) { int count = SPECPDL_INDEX (); int nesting = 0; /* This is to make sure that loadup.el gives a clear picture of what files are preloaded and when. */