Re: load-history is incorrect

Re: load-history is incorrect

[Richard Stallman]

    In Emacs 21, the `load-history' seems to be seriously flawed (unless there
    is some change in the semantics that is not reflected by the doc string).
    Many explicit requires for a library are not listed in the library's entry
    in load-history. This is true for both user libraries and standard,
    preloaded libraries.

As far as I can see, it mentions `require' when the library
required was not already loaded.

Does anyone see a problem in including a `require' item
for libraries already loaded?

Re: load-history is incorrect

[Richard Stallman]

	In Emacs 20, each explicit `require' in a library is reflected
	in the entry for that library in variable `load-history'.

	In Emacs 21, the `load-history' seems to be seriously flawed
	(unless there is some change in the semantics that is not
	reflected by the doc string). Many explicit requires for a
	library are not listed in the library's entry in load-history.

What do people think of this change?

*** fns.c	27 Dec 2004 12:44:41 -0500	1.380
--- fns.c	10 Jan 2005 18:12:38 -0500	
***************
*** 3443,3456 ****
  
    CHECK_SYMBOL (feature);
  
    tem = Fmemq (feature, Vfeatures);
  
    if (NILP (tem))
      {
        int count = SPECPDL_INDEX ();
        int nesting = 0;
- 
-       LOADHIST_ATTACH (Fcons (Qrequire, feature));
  
        /* This is to make sure that loadup.el gives a clear picture
  	 of what files are preloaded and when.  */
--- 3443,3458 ----
  
    CHECK_SYMBOL (feature);
  
+   /* Record the presence of `require' in this file
+      even if the feature specified is already loaded.  */
+   LOADHIST_ATTACH (Fcons (Qrequire, feature));
+ 
    tem = Fmemq (feature, Vfeatures);
  
    if (NILP (tem))
      {
        int count = SPECPDL_INDEX ();
        int nesting = 0;
  
        /* This is to make sure that loadup.el gives a clear picture
  	 of what files are preloaded and when.  */

Re: load-history is incorrect

[Stefan Monnier]

> 	In Emacs 20, each explicit `require' in a library is reflected
> 	in the entry for that library in variable `load-history'.

> 	In Emacs 21, the `load-history' seems to be seriously flawed
> 	(unless there is some change in the semantics that is not
> 	reflected by the doc string). Many explicit requires for a
> 	library are not listed in the library's entry in load-history.

> What do people think of this change?

Very good.  


        Stefan