[parent not found: <DNEMKBNJBGPAOPIJOOICEEMJCAAA.drew.adams@oracle.com>]
* Re: load-history is incorrect
[not found] <DNEMKBNJBGPAOPIJOOICEEMJCAAA.drew.adams@oracle.com>
@ 2005-01-11 14:29 ` Richard Stallman
2005-01-11 15:40 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2005-01-11 14:29 UTC (permalink / raw)
Cc: emacs-devel
In Emacs 20, each explicit `require' in a library is reflected
in the entry for that library in variable `load-history'.
In Emacs 21, the `load-history' seems to be seriously flawed
(unless there is some change in the semantics that is not
reflected by the doc string). Many explicit requires for a
library are not listed in the library's entry in load-history.
What do people think of this change?
*** fns.c 27 Dec 2004 12:44:41 -0500 1.380
--- fns.c 10 Jan 2005 18:12:38 -0500
***************
*** 3443,3456 ****
CHECK_SYMBOL (feature);
tem = Fmemq (feature, Vfeatures);
if (NILP (tem))
{
int count = SPECPDL_INDEX ();
int nesting = 0;
-
- LOADHIST_ATTACH (Fcons (Qrequire, feature));
/* This is to make sure that loadup.el gives a clear picture
of what files are preloaded and when. */
--- 3443,3458 ----
CHECK_SYMBOL (feature);
+ /* Record the presence of `require' in this file
+ even if the feature specified is already loaded. */
+ LOADHIST_ATTACH (Fcons (Qrequire, feature));
+
tem = Fmemq (feature, Vfeatures);
if (NILP (tem))
{
int count = SPECPDL_INDEX ();
int nesting = 0;
/* This is to make sure that loadup.el gives a clear picture
of what files are preloaded and when. */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: load-history is incorrect
2005-01-11 14:29 ` Richard Stallman
@ 2005-01-11 15:40 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2005-01-11 15:40 UTC (permalink / raw)
Cc: Drew Adams, emacs-devel
> In Emacs 20, each explicit `require' in a library is reflected
> in the entry for that library in variable `load-history'.
> In Emacs 21, the `load-history' seems to be seriously flawed
> (unless there is some change in the semantics that is not
> reflected by the doc string). Many explicit requires for a
> library are not listed in the library's entry in load-history.
> What do people think of this change?
Very good.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-11 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <MEEKKIABFKKDFJMPIOEBEEKACIAA.drew.adams@oracle.com>
2005-01-01 5:25 ` load-history is incorrect Richard Stallman
[not found] <DNEMKBNJBGPAOPIJOOICEEMJCAAA.drew.adams@oracle.com>
2005-01-11 14:29 ` Richard Stallman
2005-01-11 15:40 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.