From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: query-replace highlighting Date: Mon, 13 Dec 2004 14:51:26 -0500 Message-ID: References: <87ekhy6h5i.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1102967923 22597 80.91.229.6 (13 Dec 2004 19:58:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 13 Dec 2004 19:58:43 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 13 20:58:37 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CdwL7-0007IR-00 for ; Mon, 13 Dec 2004 20:58:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CdwVE-0004h3-9F for ged-emacs-devel@m.gmane.org; Mon, 13 Dec 2004 15:09:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CdwSz-0002VJ-Kd for emacs-devel@gnu.org; Mon, 13 Dec 2004 15:06:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CdwSw-0002Tw-UU for emacs-devel@gnu.org; Mon, 13 Dec 2004 15:06:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CdwSv-0002SO-R1 for emacs-devel@gnu.org; Mon, 13 Dec 2004 15:06:42 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CdwIn-0007jI-4Q for emacs-devel@gnu.org; Mon, 13 Dec 2004 14:56:13 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CdwEA-0005RT-PU; Mon, 13 Dec 2004 14:51:27 -0500 Original-To: Juri Linkov In-reply-to: <87ekhy6h5i.fsf@jurta.org> (message from Juri Linkov on Fri, 10 Dec 2004 04:06:33 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31076 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31076 This seems like a good feature. However, it is inconsistent to control it by giving query-replace-highlight a third possible value. For the case of isearch, we did not give search-highlight a third possible value. We made a new option, isearch-lazy-highlight. So we should make a new option, query-replace-lazy-highlight. Could you please do that? With this new feature, most of the options in the group isearch-lazy-highlight are no longer specific to isearch. It would be better to call the custom group lazy-highlight-matches, and rename all the options accordingly, making the old names aliases and marking them obsolete. The option isearch-lazy-highlight should not be renamed. But the function isearch-lazy-highlight-new-loop should not test it. Instead, the caller in isearch.el should test isearch-lazy-highlight before calling isearch-lazy-highlight-new-loop. The caller in replace.el would test query-replace-lazy-highlight instead. The custom group lazy-highlight-matches should have multiple parent groups, `isearch' and `matching'. That way, people will find it in both contexts. Would you like to do these things to finish it up right, then install your patch?