all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* The discussion about easy-menu
@ 2004-12-09 17:03 Lennart Borgman
  2004-12-09 22:37 ` Stefan Monnier
  2004-12-10  5:51 ` Richard Stallman
  0 siblings, 2 replies; 6+ messages in thread
From: Lennart Borgman @ 2004-12-09 17:03 UTC (permalink / raw)


I did not see a clear resulotion to the changes that made some old code
using easy-menu ended. Here is an example of the state at the moment with
current CVS Emacs. To be able to add a menu both when using current Emacs
and CVS Emacs I am now using something like the following:

      (easy-menu-change
        (if cvs-emacs
           '("file")
          '("files"))
        "Quick Print (to Windows Printer)"
        print-menu-spec "separator-window") ))

Should it be like this? I think it would be nice if "files" worked in CVS
Emacs too.

- Lennart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: The discussion about easy-menu
  2004-12-09 17:03 The discussion about easy-menu Lennart Borgman
@ 2004-12-09 22:37 ` Stefan Monnier
  2004-12-09 23:10   ` Lennart Borgman
  2004-12-10 23:15   ` Richard Stallman
  2004-12-10  5:51 ` Richard Stallman
  1 sibling, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2004-12-09 22:37 UTC (permalink / raw)
  Cc: Emacs Devel

> I did not see a clear resulotion to the changes that made some old code
> using easy-menu ended. Here is an example of the state at the moment with
> current CVS Emacs. To be able to add a menu both when using current Emacs
> and CVS Emacs I am now using something like the following:

>       (easy-menu-change
>         (if cvs-emacs
>            '("file")
>           '("files"))
>         "Quick Print (to Windows Printer)"
>         print-menu-spec "separator-window") ))

> Should it be like this? I think it would be nice if "files" worked in CVS
> Emacs too.

This is actually orthogonal to the easy-menu discussion.
The problem comes simply from the fact that Richard changed the key name
from "files" to "file".  He did do it as a result of the discussion,
admittedly.  AFAIK he only did it for "consistency".  It seemed a bit
gratuitous to me, although I do agree that consistency is a nice property.


        Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: The discussion about easy-menu
  2004-12-09 22:37 ` Stefan Monnier
@ 2004-12-09 23:10   ` Lennart Borgman
  2004-12-10 12:56     ` Eli Zaretskii
  2004-12-10 23:15   ` Richard Stallman
  1 sibling, 1 reply; 6+ messages in thread
From: Lennart Borgman @ 2004-12-09 23:10 UTC (permalink / raw)
  Cc: Emacs Devel

----- Original Message ----- 
From: "Stefan Monnier" <monnier@iro.umontreal.ca>


> > I did not see a clear resulotion to the changes that made some old code
> > using easy-menu ended. Here is an example of the state at the moment
with
> > current CVS Emacs. To be able to add a menu both when using current
Emacs
> > and CVS Emacs I am now using something like the following:
>
> >       (easy-menu-change
> >         (if cvs-emacs
> >            '("file")
> >           '("files"))
> >         "Quick Print (to Windows Printer)"
> >         print-menu-spec "separator-window") ))
>
> > Should it be like this? I think it would be nice if "files" worked in
CVS
> > Emacs too.
>
> This is actually orthogonal to the easy-menu discussion.
> The problem comes simply from the fact that Richard changed the key name
> from "files" to "file".  He did do it as a result of the discussion,
> admittedly.  AFAIK he only did it for "consistency".  It seemed a bit
> gratuitous to me, although I do agree that consistency is a nice property.

It is ok with me. I think consistency can save time. I just want that this
should be pointed out somewhere in the documentation, since otherwise the
change can waste time. I have no idea though were to do this.

- Lennart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: The discussion about easy-menu
  2004-12-09 17:03 The discussion about easy-menu Lennart Borgman
  2004-12-09 22:37 ` Stefan Monnier
@ 2004-12-10  5:51 ` Richard Stallman
  1 sibling, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2004-12-10  5:51 UTC (permalink / raw)
  Cc: emacs-devel

	  (easy-menu-change
	    (if cvs-emacs
	       '("file")
	      '("files"))
	    "Quick Print (to Windows Printer)"
	    print-menu-spec "separator-window") ))

    Should it be like this? I think it would be nice if "files" worked in CVS
    Emacs too.

Making it the now-incorrect call "work" would be a kludge.
However, the kludge would do no great harm, if it first verifies
that there isn't really a menu bar menu named "files", and then
uses "file" instead.

However, we would want to do something to tell users to convert.
It should display a warning somehow.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: The discussion about easy-menu
  2004-12-09 23:10   ` Lennart Borgman
@ 2004-12-10 12:56     ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2004-12-10 12:56 UTC (permalink / raw)
  Cc: monnier, emacs-devel

> From: "Lennart Borgman" <lennart.borgman.073@student.lu.se>
> Date: Fri, 10 Dec 2004 00:10:27 +0100
> Cc: Emacs Devel <emacs-devel@gnu.org>
> 
> It is ok with me. I think consistency can save time. I just want that this
> should be pointed out somewhere in the documentation, since otherwise the
> change can waste time. I have no idea though were to do this.

etc/NEWS?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: The discussion about easy-menu
  2004-12-09 22:37 ` Stefan Monnier
  2004-12-09 23:10   ` Lennart Borgman
@ 2004-12-10 23:15   ` Richard Stallman
  1 sibling, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2004-12-10 23:15 UTC (permalink / raw)
  Cc: lennart.borgman.073, emacs-devel

    The problem comes simply from the fact that Richard changed the key name
    from "files" to "file".

It is a bug that the menu item says File and the symbol name is
`files'.  It had to be fixed.  Perpetuating that bug would cause more
trouble than fixing it once and for all.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-12-10 23:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-09 17:03 The discussion about easy-menu Lennart Borgman
2004-12-09 22:37 ` Stefan Monnier
2004-12-09 23:10   ` Lennart Borgman
2004-12-10 12:56     ` Eli Zaretskii
2004-12-10 23:15   ` Richard Stallman
2004-12-10  5:51 ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.