From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: RE_TRANSLATE_P
Date: Tue, 30 Nov 2004 02:02:41 -0500
Message-ID: <E1CZ225-0003kG-SH@fencepost.gnu.org>
References: <01c4d3ab$Blat.v2.2.2$7b235d00@zahav.net.il>
	<E1CYemL-0002XE-OV@fencepost.gnu.org>
	<m3pt1x6mso.fsf@kfs-l.imdomain.dk>
Reply-To: rms@gnu.org
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1101798357 9127 80.91.229.6 (30 Nov 2004 07:05:57 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Tue, 30 Nov 2004 07:05:57 +0000 (UTC)
Cc: eliz@gnu.org, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 30 08:05:52 2004
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1CZ25A-00019c-00
	for <ged-emacs-devel@m.gmane.org>; Tue, 30 Nov 2004 08:05:52 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33)
	id 1CZ2Eb-0001JX-Ol
	for ged-emacs-devel@m.gmane.org; Tue, 30 Nov 2004 02:15:37 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1CZ2ES-0001JR-Dj
	for emacs-devel@gnu.org; Tue, 30 Nov 2004 02:15:28 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1CZ2ER-0001J4-7W
	for emacs-devel@gnu.org; Tue, 30 Nov 2004 02:15:27 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1CZ2ER-0001J1-0P
	for emacs-devel@gnu.org; Tue, 30 Nov 2004 02:15:27 -0500
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1CZ24e-00011F-BI
	for emacs-devel@gnu.org; Tue, 30 Nov 2004 02:05:20 -0500
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1CZ225-0003kG-SH; Tue, 30 Nov 2004 02:02:41 -0500
Original-To: storm@cua.dk (Kim F. Storm)
In-reply-to: <m3pt1x6mso.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:30515
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30515

    It seems like that change was made in several places, so perhaps
    we should have a ZEROP macro to test such cases in a portable
    manner.  

That would be a natural extension if it had no problems.
But as you pointed out, it has a problem:

    But the second form evals 'obj' twice, so we need a BIG FAT WARNING
    when using ZEROP, or find some other portable way to implement it.

So let's not replace an easy change with a hard one.  The specific
change I suggested has no problem, because RE_TRANSLATE_P is used only
with variables as arguments.