From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Revised lisp/progmodes/flymake.el Date: Sat, 20 Nov 2004 20:10:06 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1100999553 29508 80.91.229.6 (21 Nov 2004 01:12:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 21 Nov 2004 01:12:33 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 21 02:12:28 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CVgHE-0002WE-00 for ; Sun, 21 Nov 2004 02:12:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVgQB-0007Gw-NO for ged-emacs-devel@m.gmane.org; Sat, 20 Nov 2004 20:21:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CVgPX-0006yr-Fa for emacs-devel@gnu.org; Sat, 20 Nov 2004 20:21:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CVgPV-0006xX-Ps for emacs-devel@gnu.org; Sat, 20 Nov 2004 20:21:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVgPV-0006xJ-L6 for emacs-devel@gnu.org; Sat, 20 Nov 2004 20:21:01 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CVgGT-00085r-TM for emacs-devel@gnu.org; Sat, 20 Nov 2004 20:11:42 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CVgEw-0008WM-80; Sat, 20 Nov 2004 20:10:06 -0500 Original-To: CHENG Gao In-reply-to: (message from CHENG Gao on Fri, 19 Nov 2004 23:37:26 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30131 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30131 Attached is a revised flymake.el. What I have done includes: 1. Removed XEmacs compatibility code. I think it does not make sense to maintain XEmacs compatibility with Emacs bundled files. We don't want to do that unless Pavel likes it. 2. Following Coding Conventions to remove close-parentheses on lines by themselves. 3. Restructure and rewrite document strings to tips for documentation strings. But for some functions that I dont know their purposes, I just capitalized the first letter and add period at the end. These are changes we do want to make, since they directly follow coding conventions. 4. Add eval-when-compile to one occurence or (require 'compile). If that's correct (I don't know), it is a good change. 5. To accomodate documentation string, I changed function flymake-get-common-path-prefix from flymake-get-common-path-prefix (string-one string-two) to flymake-get-common-path-prefix (path1 path2) and change the code to use new arg names. That is an improvement. However, under GNU conventions, these should not be called "paths" at all. They are file names, or so it appears. That's another change that should be made, but perhaps not now.