From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Revised lisp/progmodes/flymake.el
Date: Sat, 20 Nov 2004 20:10:06 -0500 [thread overview]
Message-ID: <E1CVgEw-0008WM-80@fencepost.gnu.org> (raw)
In-Reply-To: <llcxluix.fsf@gmail.com> (message from CHENG Gao on Fri, 19 Nov 2004 23:37:26 +0800)
Attached is a revised flymake.el. What I have done includes:
1. Removed XEmacs compatibility code. I think it does not make sense to
maintain XEmacs compatibility with Emacs bundled files.
We don't want to do that unless Pavel likes it.
2. Following Coding Conventions to remove close-parentheses on lines by
themselves.
3. Restructure and rewrite document strings to tips for documentation
strings.
But for some functions that I dont know their purposes, I just
capitalized the first letter and add period at the end.
These are changes we do want to make, since they directly follow
coding conventions.
4. Add eval-when-compile to one occurence or (require 'compile).
If that's correct (I don't know), it is a good change.
5. To accomodate documentation string, I changed function
flymake-get-common-path-prefix from
flymake-get-common-path-prefix (string-one string-two)
to
flymake-get-common-path-prefix (path1 path2)
and change the code to use new arg names.
That is an improvement.
However, under GNU conventions, these should not be called
"paths" at all. They are file names, or so it appears.
That's another change that should be made, but perhaps not now.
prev parent reply other threads:[~2004-11-21 1:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 15:37 Revised lisp/progmodes/flymake.el CHENG Gao
2004-11-19 15:51 ` David Kastrup
2004-11-19 16:03 ` CHENG Gao
2004-11-20 10:05 ` Eli Zaretskii
2004-11-19 16:54 ` CHENG Gao
2004-11-21 1:10 ` Richard Stallman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1CVgEw-0008WM-80@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.