From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: interactive-p fix for table.el Date: Wed, 17 Nov 2004 00:04:00 -0500 Message-ID: References: <20041115.104310.34004663.Takaaki.Ota@am.sony.com> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1100668028 11129 80.91.229.6 (17 Nov 2004 05:07:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 17 Nov 2004 05:07:08 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 17 06:07:02 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CUI22-0000J4-00 for ; Wed, 17 Nov 2004 06:07:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUIAo-0002sT-Q2 for ged-emacs-devel@m.gmane.org; Wed, 17 Nov 2004 00:16:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUI9C-000236-3E for emacs-devel@gnu.org; Wed, 17 Nov 2004 00:14:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUI9A-00021k-Df for emacs-devel@gnu.org; Wed, 17 Nov 2004 00:14:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUI9A-00021K-3y for emacs-devel@gnu.org; Wed, 17 Nov 2004 00:14:24 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUI0E-0007k0-Ll for emacs-devel@gnu.org; Wed, 17 Nov 2004 00:05:10 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CUHz6-0001Re-7i; Wed, 17 Nov 2004 00:04:00 -0500 Original-To: Tak Ota In-reply-to: <20041115.104310.34004663.Takaaki.Ota@am.sony.com> (message from Tak Ota on Mon, 15 Nov 2004 10:43:10 -0800 (PST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29961 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29961 In cases where it only controls a message, as here, (setq cells (1- cells)) (and (> n 0) (> cells 0))))) (table-recognize-cell 'force) ! (if (interactive-p) (message "Sequencing...done")) )) it is ok to use interactive-p. In some cases, both the old code and the new code must be wrong. For instance, *************** *** 5346,5352 **** This feature is disabled when `table-disable-incompatibility-warning' is non-nil. The warning is done only once per session for each item." (unless (and table-disable-incompatibility-warning ! (not (interactive-p))) (cond ((and (featurep 'xemacs) (not (get 'table-disable-incompatibility-warning 'xemacs))) (put 'table-disable-incompatibility-warning 'xemacs t) --- 5353,5359 ---- This feature is disabled when `table-disable-incompatibility-warning' is non-nil. The warning is done only once per session for each item." (unless (and table-disable-incompatibility-warning ! (not (called-interactively-p))) (cond ((and (featurep 'xemacs) (not (get 'table-disable-incompatibility-warning 'xemacs))) (put 'table-disable-incompatibility-warning 'xemacs t) Since this function is not interactive, both interactive-p and called-interactively-p will always return nil in this function. Whatever you want to do, you need to do it some other way.