* type of port of url
@ 2004-10-27 5:18 Masatake YAMATO
2004-10-28 6:25 ` Richard Stallman
2004-11-11 18:09 ` running mm-destroy-parts when (mm-display-part handle) returns inline Masatake YAMATO
0 siblings, 2 replies; 4+ messages in thread
From: Masatake YAMATO @ 2004-10-27 5:18 UTC (permalink / raw)
Cc: emacs-devel
Dear, Sir
I'm trying your url package.
I have a question about the port slot of url object passed to
url-protocol, e.g. url-irc.
Is the port a string or integer?
In the function, url-irc, it seems that url-port is expected to return a string.
However, it returns an integer. Attached patch is required to use url-irc.el.
string-to-int is also used in some other places in url packages to
convert the type of port.
Masatake YAMATO
Index: lisp/url/url-irc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/url/url-irc.el,v
retrieving revision 1.5
diff -u -r1.5 url-irc.el
--- lisp/url/url-irc.el 19 Oct 2004 21:36:00 -0000 1.5
+++ lisp/url/url-irc.el 27 Oct 2004 05:14:04 -0000
@@ -61,7 +61,9 @@
;;;###autoload
(defun url-irc (url)
(let* ((host (url-host url))
- (port (string-to-int (url-port url)))
+ (port (if (stringp port)
+ (string-to-int (url-port url))
+ (url-port url)))
(pass (url-password url))
(user (url-user url))
(chan (url-filename url)))
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: type of port of url
2004-10-27 5:18 type of port of url Masatake YAMATO
@ 2004-10-28 6:25 ` Richard Stallman
2004-11-01 17:40 ` Masatake YAMATO
2004-11-11 18:09 ` running mm-destroy-parts when (mm-display-part handle) returns inline Masatake YAMATO
1 sibling, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2004-10-28 6:25 UTC (permalink / raw)
Cc: emacs-devel
You may not get an answer from Bill Perry. If you don't get an answer,
how about if you clean up this mess as best you can?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: type of port of url
2004-10-28 6:25 ` Richard Stallman
@ 2004-11-01 17:40 ` Masatake YAMATO
0 siblings, 0 replies; 4+ messages in thread
From: Masatake YAMATO @ 2004-11-01 17:40 UTC (permalink / raw)
Cc: emacs-devel
> You may not get an answer from Bill Perry. If you don't get an answer,
> how about if you clean up this mess as best you can?
Sorry to be late to answer.
I will try on the issue I reported.
Masatake YAMATO
^ permalink raw reply [flat|nested] 4+ messages in thread
* running mm-destroy-parts when (mm-display-part handle) returns inline
2004-10-27 5:18 type of port of url Masatake YAMATO
2004-10-28 6:25 ` Richard Stallman
@ 2004-11-11 18:09 ` Masatake YAMATO
1 sibling, 0 replies; 4+ messages in thread
From: Masatake YAMATO @ 2004-11-11 18:09 UTC (permalink / raw)
Cc: emacs-devel
Dear Sir,
I'm trying url-mm-callback in the url package with
emacs-w3m web browser.
When (mm-display-part handle) returns inline, follwoing
code sequence are executed:
(display-buffer (current-buffer))
(mm-destroy-parts handle)
As the result, the user see nothing.
The inline handler renders the result on the (current-buffer).
The rendering result is destroyed by (mm-destroy-parts handle).
I don't know whether this is the special case of emacs-w3m or not.
However, the attached patch will fix my problem. I think the impact
of this patch is small; and the patch helps all inline handlers
which manages rendered items on the (current-buffer).
BTW, is there any document about the url package?
Regards,
Masatake YAMATO
2004-11-12 Masatake YAMATO <jet@gyve.org>
* url.el (url-mm-callback): Call `mm-destroy-parts'
when the buffer is killed.
Index: lisp/url/url.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/url/url.el,v
retrieving revision 1.6
diff -u -r1.6 url.el
--- lisp/url/url.el 16 Oct 2004 15:02:46 -0000 1.6
+++ lisp/url/url.el 11 Nov 2004 18:05:40 -0000
@@ -207,7 +207,10 @@
(message "Viewing externally")
(kill-buffer (current-buffer)))
(display-buffer (current-buffer))
- (mm-destroy-parts handle)))))
+ (add-hook 'kill-buffer-hook
+ `(lambda () (mm-destroy-parts ',handle))
+ nil
+ t)))))
(defun url-mm-url (url)
"Retrieve URL and pass to the appropriate viewing application."
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-11-11 18:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-27 5:18 type of port of url Masatake YAMATO
2004-10-28 6:25 ` Richard Stallman
2004-11-01 17:40 ` Masatake YAMATO
2004-11-11 18:09 ` running mm-destroy-parts when (mm-display-part handle) returns inline Masatake YAMATO
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.