From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix `window-at' and `coordinates-in-window-p' Date: Sat, 24 Jul 2004 15:44:04 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1090698277 16125 80.91.224.253 (24 Jul 2004 19:44:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 24 Jul 2004 19:44:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 24 21:44:32 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BoSRc-00079h-00 for ; Sat, 24 Jul 2004 21:44:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BoSUZ-0003Kw-Bs for ged-emacs-devel@m.gmane.org; Sat, 24 Jul 2004 15:47:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BoSUO-0003I5-MB for emacs-devel@gnu.org; Sat, 24 Jul 2004 15:47:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BoSUN-0003HZ-Kc for emacs-devel@gnu.org; Sat, 24 Jul 2004 15:47:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BoSUN-0003HO-Gi for emacs-devel@gnu.org; Sat, 24 Jul 2004 15:47:23 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BoSRB-0002ql-Qt for emacs-devel@gnu.org; Sat, 24 Jul 2004 15:44:05 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1BoSRA-0001Gj-Si; Sat, 24 Jul 2004 15:44:04 -0400 Original-To: lorentey@elte.hu (=?iso-8859-2?Q?L=F5rentey_K=E1roly?=) In-reply-to: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25929 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25929 The comments define FRAME_CANON_X_FROM_PIXEL_X and friends as converting units, which means that they should not offset by the internal border. That change might be wrong for other uses of these macros. That's why I fixed this case by doing that in the code that uses the macros. However, other uses of the same macros could have similar bugs. Could you look at the other uses of these macros?