From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Discrepancy in definition/use of match-data?
Date: Fri, 11 Jun 2004 21:51:06 -0400 [thread overview]
Message-ID: <E1BYxfm-0007Rn-Tl@fencepost.gnu.org> (raw)
In-Reply-To: <x5vfhzarwo.fsf@lola.goethe.zz> (message from David Kastrup on 11 Jun 2004 01:56:39 +0200)
Now the obvious solution to that would be to make unsuccessful
matches void the match-data, too.
That might be a good thing to do, except that doing it now is likely
to delay the release.
So my proposal is the following plan:
Before next release:
match-data gets voided upon entry of a filter or sentinel, like it is
being done now. With void match-data, match-beginning and so on flag
an error irrespective of their argument. The match-data is only
touched by a successful match. Once a match has been successful,
match-beginning and so on will not flag errors for positive
arguments, but return nil (as documented).
In order to have a better chance of catching such
use-before-valid-match situations, it might be a good idea also to
void the match-data in the main loop.
Voiding in the main loop was exactly the idea that occurred to me.
So let's do all of this now.
After the next release, I would like to have unsuccessful matches
also void the match-data, making the use of the above quoted idiom
illegal.
I agree. (But please, let's say "cause an error", not "illegal".
Nobody is going to be jailed for doing this.)
We should do this change right after the next release so that Emacs
core developers and those for add-on packages have enough time testing
it, finding the problematic code and fixing it for the next release
after that.
We could do it right now in the Unicode branch. That way, we'd assure
it will get into the following major release, but detection of code
that needs changing could start right away.
prev parent reply other threads:[~2004-06-12 1:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 15:37 Discrepancy in definition/use of match-data? David Kastrup
2004-06-10 23:01 ` Richard Stallman
2004-06-10 23:56 ` David Kastrup
2004-06-11 8:34 ` Stephen J. Turnbull
2004-06-11 8:54 ` David Kastrup
2004-06-12 6:45 ` Stephen J. Turnbull
2004-06-12 9:03 ` David Kastrup
2004-06-13 0:01 ` Richard Stallman
2004-06-14 5:06 ` Stephen J. Turnbull
2004-06-14 9:05 ` David Kastrup
2004-06-14 10:05 ` Stephen J. Turnbull
2004-06-16 7:13 ` Stephen J. Turnbull
2004-06-19 3:19 ` Richard Stallman
2004-06-23 9:53 ` Stephen J. Turnbull
2004-06-19 3:19 ` Richard Stallman
2004-06-12 1:51 ` Richard Stallman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1BYxfm-0007Rn-Tl@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.