Any problems with this change?

Any problems with this change?

[Richard Stallman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2950 bytes --]

Does anyone see a problem with this change?


To: emacs-pretest-bug@gnu.org
From: hakan.granath@kau.se (=?iso-8859-1?q?H=E5kan?= Granath)
Date: 22 Mar 2004 11:11:03 +0100
Subject: dired-move-to-filename-regexp
Sender: emacs-pretest-bug-bounces+rms=gnu.org@gnu.org

In my locale sv_SE the output of ls -l may look like

  drwx------    2 hakan    users        4096 15 mar 14.47 bin

The time format (14.47 instead of 14:47) gives problems in dired. The
following patch redefines 'dired-move-to-filename-regexp' and solves
the problem for me. However, I do not know if this is the correct fix.

Best regards,

Håkan Granath


*** dired.el.bak        2004-03-22 10:47:01.000000000 +0100
--- dired.el    2004-03-22 10:48:02.000000000 +0100
***************
*** 1601,1607 ****
         (s " ")
         (yyyy "[0-9][0-9][0-9][0-9]")
         (dd "[ 0-3][0-9]")
!        (HH:MM "[ 0-2][0-9]:[0-5][0-9]")
         (seconds "[0-6][0-9]\\([.,][0-9]+\\)?")
         (zone "[-+][0-2][0-9][0-5][0-9]")
         (iso-mm-dd "[01][0-9]-[0-3][0-9]")
--- 1601,1607 ----
         (s " ")
         (yyyy "[0-9][0-9][0-9][0-9]")
         (dd "[ 0-3][0-9]")
!        (HH:MM "[ 0-2][0-9][:.][0-5][0-9]")
         (seconds "[0-6][0-9]\\([.,][0-9]+\\)?")
         (zone "[-+][0-2][0-9][0-5][0-9]")
         (iso-mm-dd "[01][0-9]-[0-3][0-9]")



In GNU Emacs 21.3.50.20 (i686-pc-linux-gnu, X toolkit)
 of 2004-03-19 on ws-iva176.inin.local
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: sv_SE
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  auto-image-file-mode: t
  display-time-mode: t
  partial-completion-mode: t
  recentf-mode: t
  show-paren-mode: t
  iswitchb-mode: t
  auto-compression-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <report-emacs-bug>

Recent messages:
Loading image-file...done
Fontifying .emacs... (regexps.............)
Loading image-file...done
Loading dictionary-init (compiled; note, source file is newer)...done
Loading server...done
Loading time-date...done
It took 1 seconds to run .emacs.
Scanning buffer for index (  0%)
Scanning buffer for index (100%)
Loading emacsbug...done


_______________________________________________
Emacs-pretest-bug mailing list
Emacs-pretest-bug@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-pretest-bug

Re: Any problems with this change?

[Juri Linkov]

Richard Stallman <rms@gnu.org> writes:
> Does anyone see a problem with this change?
>
> To: emacs-pretest-bug@gnu.org
> From: hakan.granath@kau.se (=?iso-8859-1?q?H=E5kan?= Granath)
> Date: 22 Mar 2004 11:11:03 +0100
> Subject: dired-move-to-filename-regexp
> Sender: emacs-pretest-bug-bounces+rms=gnu.org@gnu.org
>
> In my locale sv_SE the output of ls -l may look like
>
>   drwx------    2 hakan    users        4096 15 mar 14.47 bin
>
> The time format (14.47 instead of 14:47) gives problems in dired. The
> following patch redefines 'dired-move-to-filename-regexp' and solves
> the problem for me. However, I do not know if this is the correct fix.

I don't see a problem with this change.

However, I have a related problem.

The function `dired-mark-sexp' don't work when dates in the dired buffer
are in ISO format, because month names are hard-coded in its regexp.

I propose to replace this regexp with the variable
`dired-move-to-filename-regexp'.  Luckily it will work here because
this variable has the date in its first parenthetical subexpression,
and `dired-mark-sexp' expects the start of the date in the first
subexpression too.

Index: emacs/lisp/dired-x.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/dired-x.el,v
retrieving revision 1.53
diff -c -r1.53 dired-x.el
*** emacs/lisp/dired-x.el	23 Mar 2004 07:38:57 -0000	1.53
--- emacs/lisp/dired-x.el	25 Mar 2004 22:06:54 -0000
***************
*** 1517,1524 ****
                ;; Karsten Wenger <kw@cis.uni-muenchen.de> fixed uid.
                (setq uid (buffer-substring (+ (point) 1)
  					  (progn (forward-word 1) (point))))
!               (re-search-forward "\\(Jan\\|Feb\\|Mar\\|Apr\\|May\\|Jun\\|\
! Jul\\|Aug\\|Sep\\|Oct\\|Nov\\|Dec\\)")
                (goto-char (match-beginning 1))
                (forward-char -1)
                (setq size (string-to-int (buffer-substring (save-excursion
--- 1517,1523 ----
                ;; Karsten Wenger <kw@cis.uni-muenchen.de> fixed uid.
                (setq uid (buffer-substring (+ (point) 1)
  					  (progn (forward-word 1) (point))))
!               (re-search-forward dired-move-to-filename-regexp)
                (goto-char (match-beginning 1))
                (forward-char -1)
                (setq size (string-to-int (buffer-substring (save-excursion

-- 
Juri Linkov
http://www.jurta.org/emacs/