From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Using overlay in register
Date: Fri, 19 Mar 2004 23:49:04 -0500 [thread overview]
Message-ID: <E1B4YPw-0007h8-Ef@fencepost.gnu.org> (raw)
In-Reply-To: <20040318.193346.21592706.jet@gyve.org> (message from Masatake YAMATO on Thu, 18 Mar 2004 19:33:46 +0900 (JST))
This is a very good idea. Thanks for working on it.
I see a possible bug here:
+(defun register-put-overlay-at-point (register)
+ "Put a overlay associated with REGISTER at the point."
+ (let ((overlay (make-overlay (point)
+ (1+ (point))
+ (current-buffer)
This will get an error at the end of the buffer.
What should it do at the end? Make an empty overlay?
It could have a before-string, perhaps.
+(defun register-get-overlay-position (overlay)
+ "Get the position for OVERLAY."
+ (min (overlay-start overlay) (overlay-end overlay)))
What's the purpose of using min here?
Why not just use overlay-start?
(In some places you did so.)
next prev parent reply other threads:[~2004-03-20 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 10:33 Using overlay in register Masatake YAMATO
2004-03-20 4:49 ` Richard Stallman [this message]
2004-03-21 14:03 ` Masatake YAMATO
2004-03-22 5:24 ` Richard Stallman
2004-03-22 5:24 ` Richard Stallman
2004-03-22 8:00 ` overlay-start > overlay-end Masatake YAMATO
2004-03-23 3:04 ` Richard Stallman
2004-03-23 8:45 ` Masatake YAMATO
2004-03-23 14:18 ` Stefan Monnier
2004-03-24 5:34 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1B4YPw-0007h8-Ef@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.