From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [kzeitler@lucent.com: Re: compose key on SUN keyboard creates 2 characters (and beeps)] Date: Fri, 09 Jan 2004 06:46:37 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1073683765 15939 80.91.224.253 (9 Jan 2004 21:29:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 9 Jan 2004 21:29:25 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jan 09 22:29:18 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Af4Bx-00068R-00 for ; Fri, 09 Jan 2004 22:29:17 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Af4Bx-00066i-00 for ; Fri, 09 Jan 2004 22:29:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Af58w-0001vd-9I for emacs-devel@quimby.gnus.org; Fri, 09 Jan 2004 17:30:14 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Af587-0001ug-RK for emacs-devel@gnu.org; Fri, 09 Jan 2004 17:29:23 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Af3ez-00053A-7P for emacs-devel@gnu.org; Fri, 09 Jan 2004 15:55:44 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Aew44-0003TQ-3y for emacs-devel@gnu.org; Fri, 09 Jan 2004 07:48:36 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.24) id 1Aev65-00057F-1m; Fri, 09 Jan 2004 06:46:37 -0500 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19118 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19118 Can somebody who knows these issues better than I do please think about whether this is correct? X-Authentication-Warning: sfsw51.de.lucent.com: kzeitler set sender to kzeitler@lucent.com using -f To: rms@gnu.org Subject: Re: compose key on SUN keyboard creates 2 characters (and beeps) X-Emacs-Acronym: Every Moron Assumes CCA is Superior From: Klaus Zeitler Date: 08 Jan 2004 10:15:58 +0100 In-Reply-To: X-Spam-Status: No, hits=-2.1 required=5.0 tests=IN_REP_TO,PATCH_CONTEXT_DIFF,REFERENCES,USER_AGENT_GNUS_UA, X_AUTH_WARNING version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) --=-=-= >>>>> "Richard" == Richard Stallman writes: Richard> Richard> Could you tell me if this change is still needed? Richard> If it is, could you send a diff -c so I can be sure to Richard> make the change right? yes, it's still needed. Here's a patch that works for Solaris. Don't know about other OS. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=compose-key.patch Content-Description: patch for compose key handling in xterm.c *** xterm.c Thu Jan 8 09:31:58 2004 --- xterm.c.~1.823.~ Thu Jan 8 09:31:00 2004 *************** *** 6305,6316 **** &compose_status); #endif - /* Check if we're processing a composed key. In this case we need - 3 key presses till the key is complete. */ - if ((compose_status.chars_matched == 1) || - (compose_status.chars_matched == 2)) - goto OTHER; - orig_keysym = keysym; if (numchars > 1) --- 6305,6310 ---- --=-=-= as I said in my original post instead of these lines it also works if one checks nbytes instead, i.e. --- snip --- if (nbytes <= 0) goto OTHER; --- snip --- should also work. Since you asked if this is still needed I'm guessing that the compose key works for other operating systems, e.g. GNU/Linux. Is that so? Klaus -- ------------------------------------------ | Klaus Zeitler Lucent Technologies | | Email: kzeitler@lucent.com | ------------------------------------------ --- Early to rise, and early to bed / Makes a man healthy but socially dead --=-=-=--