From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: add-hook Date: Wed, 12 Nov 2003 15:02:15 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1068668198 3865 80.91.224.253 (12 Nov 2003 20:16:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 12 Nov 2003 20:16:38 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Nov 12 21:16:34 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AK1Pm-0002UX-00 for ; Wed, 12 Nov 2003 21:16:34 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AK1Pm-000505-00 for ; Wed, 12 Nov 2003 21:16:34 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AK2JX-0007tT-0O for emacs-devel@quimby.gnus.org; Wed, 12 Nov 2003 16:14:11 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AK2H7-000754-Rv for emacs-devel@gnu.org; Wed, 12 Nov 2003 16:11:41 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AK2Ga-0006sU-2z for emacs-devel@gnu.org; Wed, 12 Nov 2003 16:11:39 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AK2GZ-0006qX-SI for emacs-devel@gnu.org; Wed, 12 Nov 2003 16:11:07 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.24) id 1AK1Bv-0005CS-T4; Wed, 12 Nov 2003 15:02:15 -0500 Original-To: Miles Bader In-reply-to: (message from Miles Bader on 11 Nov 2003 11:26:33 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17781 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17781 ;; Setting `local' to t ensures that the var will be modified with `set' ;; whereas a setting of nil implies that the hook will be modified with ;; `set-default', so the safe setting is t. The only case where we ;; want to use the unsafe setting of nil is when we indeed want to change ;; the global part of the hook and there is both a local and a global part ;; (i.e when local == nil and when there's a t in the hook's content). That comment may be correct, but it is still hard to understand. Also, the variable ought to be renamed. t does not mean the hook is local or that anything is local.