all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: cua: quiet warning messages
Date: Sat, 21 Jun 2003 23:01:20 -0400	[thread overview]
Message-ID: <E19Tv6W-0000TC-KG@fencepost.gnu.org> (raw)
In-Reply-To: <200306161912.h5GJCwM1020131@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu)

    > Note that _any_ symbol other than `nil' or `-' should turn the mode
    > _on_.  `toggle' is a symbol, it is not `nil' and not `-'.

    That's also how define-minor-mode behaves.

I don't think so.  This code

	 ;; Use `toggle' rather than (if ,mode 0 1) so that using
	 ;; repeat-command still does the toggling correctly.
	 (interactive (list (or current-prefix-arg 'toggle)))
	 (setq ,mode
	       (cond
		((eq arg 'toggle) (not ,mode))

seems to handling `toggle' by toggling the mode,
not by turning it off, which the spec says it should do.

    The warning is thus there so that when it ends up turning the mode
    OFF, it tells the user that it might not be doing what the
    user expected.  If the user (or author) really meant to turn the
    mode off, she should pass a -1 argument to make it clear that
    she knows what she's doing.

You are right, and yet it is also true that this contradicts the
spec.

The spec is not cast in stone; we might want to change it.  But
changes in such a general and basic spec should be thought about as
such, and I don't think they have been.

Can I have your comments and proposals for what to do?

  parent reply	other threads:[~2003-06-22  3:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-16 17:04 cua: quiet warning messages Michael Mauger
2003-06-16 18:47 ` Luc Teirlinck
2003-06-16 19:12   ` Stefan Monnier
2003-06-16 19:41     ` Luc Teirlinck
2003-06-22  3:01     ` Richard Stallman [this message]
2003-06-23 17:00       ` Stefan Monnier
2003-07-01 15:17         ` Richard Stallman
2003-07-04  0:47           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E19Tv6W-0000TC-KG@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.