From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: recent emacs font problems? Date: Wed, 28 May 2003 09:55:18 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1054130314 4204 80.91.224.249 (28 May 2003 13:58:34 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 28 May 2003 13:58:34 +0000 (UTC) Cc: handa@m17n.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed May 28 15:58:31 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19L1Rn-00015R-00 for ; Wed, 28 May 2003 15:58:31 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19L1fz-0007BU-00 for ; Wed, 28 May 2003 16:13:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19L1SY-0003p1-Ao for emacs-devel@quimby.gnus.org; Wed, 28 May 2003 09:59:18 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19L1Q3-0002yk-Im for emacs-devel@gnu.org; Wed, 28 May 2003 09:56:43 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19L1Pe-0002l2-60 for emacs-devel@gnu.org; Wed, 28 May 2003 09:56:18 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19L1Oh-0002HR-Gc for emacs-devel@gnu.org; Wed, 28 May 2003 09:55:19 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.20) id 19L1Og-0002IM-Oi; Wed, 28 May 2003 09:55:18 -0400 Original-To: John Paul Wallington In-reply-to: (message from John Paul Wallington on Wed, 28 May 2003 06:14:48 +0100) Original-cc: miles@gnu.org Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14372 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14372 Is this the right fix (not properly tested) ? --- /build/emacs/src/xfaces.c.~1.277.~ Wed May 28 06:00:50 2003 +++ /build/emacs/src/xfaces.c Wed May 28 06:10:40 2003 @@ -6584,9 +6584,7 @@ frame_font = Fassq (Qfont, f->param_alist); xassert (CONSP (frame_font) && STRINGP (XCDR (frame_font))); frame_font = XCDR (frame_font); - /* Specify 0 for FORCE_P here, so that we don't override - a :family attribute specified for `default' for new frames. */ - set_lface_from_font_name (f, lface, frame_font, 0, 1); + set_lface_from_font_name (f, lface, frame_font, 1, 1); } #endif /* HAVE_WINDOW_SYSTEM */ That is not correct. It would bring back a bug I fixed recently. I think it was the following bug. Date: Thu, 15 May 2003 09:59:01 +0200 (CEST) From: Klaus Straubinger To: bug-gnu-emacs@gnu.org If the font family of the default face is changed with (set-face-attribute 'default nil :family "fixed") then this does not change the face's font for subsequent frames, as can be seen with the evaluation of (face-font 'default) in the first frame and in a second, created with C-x 5 2, respectively. I found that that call to set_lface_from_font_name was clobbering the family that had come from the new-frame default.