From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [joe@zircon.seattle.wa.us: skeleton.el _ versus @] Date: Mon, 24 Mar 2003 14:27:28 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1048534312 19735 80.91.224.249 (24 Mar 2003 19:31:52 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 24 Mar 2003 19:31:52 +0000 (UTC) Cc: joe@zircon.seattle.wa.us Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 24 20:31:50 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18xXfi-000589-00 for ; Mon, 24 Mar 2003 20:31:50 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18xXgK-0003cp-00 for ; Mon, 24 Mar 2003 20:32:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18xXdf-0006ZD-09 for emacs-devel@quimby.gnus.org; Mon, 24 Mar 2003 14:29:43 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18xXdH-0006Cr-00 for emacs-devel@gnu.org; Mon, 24 Mar 2003 14:29:19 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18xXcX-0005Po-00 for emacs-devel@gnu.org; Mon, 24 Mar 2003 14:28:33 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.10.13) id 18xXbU-0004Wj-00 for emacs-devel@gnu.org; Mon, 24 Mar 2003 14:27:28 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18xXbU-0005rK-00; Mon, 24 Mar 2003 14:27:28 -0500 Original-To: emacs-devel@gnu.org, occitan@esperanto.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12573 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12573 Does anyone know enough about skeleton.el to think intelligently about this issue? ------- Start of forwarded message ------- Date: 23 Mar 2003 23:55:35 -0000 From: Joe Kelsey To: bug-gnu-emacs@gnu.org cc: mmm-mode-discuss@lists.sourceforge.net Subject: skeleton.el _ versus @ Sender: bug-gnu-emacs-bounces+rms=gnu.org@gnu.org In GNU Emacs 21.2.1 (i386--freebsd, X toolkit, Xaw3d scroll bars) of 2002-11-08 on zircon.zircon.seattle.wa.us skeleton.el confuses the roles of _ and @. _ serves two purposes: mark the "interesting" skeleton-point, and mark region-skip points, depending on whether or not the skeleton is being inserted in a plain context, or in a "region" context. @ serves as a "back-up" setting for skeleton-point and also to mark the skeleton-positions. My contention is that the use of @ as a backup to _ in setting skeleton-point is incorrect. When a skeleton contains both @ and _ markers, obviously the _ should be used to set the skeleton-point and the @ should be used to set skeleton-positions when the skeleton is used in simple insertion mode. When the skeleton is used in region-list-context mode, there must be multiple occurrences of _ to mark where the insertion code is supposed to skip to the end of the next region. In this case, there probably aren't any @ markers. The first _ can serve as skeleton-point. If a simple skeleton is used without any _ markers, then the user hasn't thought about where they want point to end up and it doesn't really matter where it ends up. I propose the following modification to skeleton.el: - --- lisp/skeleton.el.orig Sat Jul 14 04:21:08 2001 +++ lisp/skeleton.el Sun Mar 23 15:28:03 2003 @@ -453,8 +453,7 @@ ((eq element '|) (unless skeleton-modified (pop skeleton))) ((eq element '@) - - (push (point) skeleton-positions) - - (unless skeleton-point (setq skeleton-point (point)))) + (push (point) skeleton-positions)) ((eq 'quote (car-safe element)) (eval (nth 1 element))) ((or (stringp (car-safe element)) Basically, this removes the setting of skeleton-point from the @ actions. /Joe _______________________________________________ Bug-gnu-emacs mailing list Bug-gnu-emacs@gnu.org http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs ------- End of forwarded message -------