From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: bug/feature - emacs doesn't tell you about keys with multiple prefixes Date: Thu, 20 Mar 2003 03:45:31 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <15932.56789.564317.739477@hkn.eecs.berkeley.edu> <200303161014.h2GAE90Q009917@rum.cs.yale.edu> <200303171635.h2HGZSJw013765@rum.cs.yale.edu> <200303181616.h2IGGLjN018636@rum.cs.yale.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1048150268 3026 80.91.224.249 (20 Mar 2003 08:51:08 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2003 08:51:08 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Mar 20 09:51:07 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18vvlT-0000mg-00 for ; Thu, 20 Mar 2003 09:51:07 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18vvmd-0000GA-00 for ; Thu, 20 Mar 2003 09:52:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18vvjL-00042S-08 for emacs-devel@quimby.gnus.org; Thu, 20 Mar 2003 03:48:55 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18vviw-0003yx-00 for emacs-devel@gnu.org; Thu, 20 Mar 2003 03:48:30 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18vviE-0003cH-00 for emacs-devel@gnu.org; Thu, 20 Mar 2003 03:47:47 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.10.13) id 18vvg4-0002Ou-00 for emacs-devel@gnu.org; Thu, 20 Mar 2003 03:45:32 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18vvg3-00055G-00; Thu, 20 Mar 2003 03:45:31 -0500 Original-To: "Stefan Monnier" In-reply-to: <200303181616.h2IGGLjN018636@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu) Original-cc: quarl@hkn.eecs.berkeley.edu Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12482 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12482 > It can't use rassq now; it has to check each previous occurrence of the same > keymap. Huh?! That's exactly what the code does. I verified it correcly breaks such cycles before posting the message. Now I see why that is so--it is because you update MAPS at the end of the loop. But the result is that the code is both more complex and slower than a simple loop that looks at each element of MAPS. So would you please change it to work that way?