From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: bug/feature - emacs doesn't tell you about keys with multiple prefixes Date: Tue, 18 Mar 2003 08:21:46 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <15932.56789.564317.739477@hkn.eecs.berkeley.edu> <200303161014.h2GAE90Q009917@rum.cs.yale.edu> <200303171635.h2HGZSJw013765@rum.cs.yale.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1047993810 14960 80.91.224.249 (18 Mar 2003 13:23:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 18 Mar 2003 13:23:30 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Mar 18 14:23:27 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18vH3R-0003qb-00 for ; Tue, 18 Mar 2003 14:22:57 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18vH3i-00026C-00 for ; Tue, 18 Mar 2003 14:23:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18vH2t-0006tD-05 for emacs-devel@quimby.gnus.org; Tue, 18 Mar 2003 08:22:23 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18vH2W-0006V7-00 for emacs-devel@gnu.org; Tue, 18 Mar 2003 08:22:00 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18vH2R-0006I0-00 for emacs-devel@gnu.org; Tue, 18 Mar 2003 08:21:57 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18vH2J-00062j-00 for emacs-devel@gnu.org; Tue, 18 Mar 2003 08:21:47 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18vH2I-0000ft-00; Tue, 18 Mar 2003 08:21:46 -0500 Original-To: "Stefan Monnier" In-reply-to: <200303171635.h2HGZSJw013765@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu) Original-cc: quarl@hkn.eecs.berkeley.edu Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12436 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12436 The new code has a bug: it finds just the last occurrence of the same keymap and tests whether the prefix for that occurrence is an initial segment. What if the last occurrence isn't but another occurrence is? In that case, it won't detect the cycle. I suspect that when M-a, M-b, and M-a M-b are the same keymap, this code won't compare the M-a with the M-a M-b. It can't use rassq now; it has to check each previous occurrence of the same keymap.