From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: regexp-opt-group Date: Sun, 19 Jan 2003 19:50:33 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1043024722 28444 80.91.224.249 (20 Jan 2003 01:05:22 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 20 Jan 2003 01:05:22 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18aQNM-0007OV-00 for ; Mon, 20 Jan 2003 02:05:20 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18aQXz-0006pf-00 for ; Mon, 20 Jan 2003 02:16:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18aQAM-0004No-01 for emacs-devel@quimby.gnus.org; Sun, 19 Jan 2003 19:51:54 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18aQ9i-0004DP-00 for emacs-devel@gnu.org; Sun, 19 Jan 2003 19:51:14 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18aQ9M-00044x-00 for emacs-devel@gnu.org; Sun, 19 Jan 2003 19:50:52 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18aQ93-00042u-00 for emacs-devel@gnu.org; Sun, 19 Jan 2003 19:50:33 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18aQ93-0006UE-00; Sun, 19 Jan 2003 19:50:33 -0500 Original-To: bojohan@helm.dd.chalmers.se (Johan =?iso-8859-1?q?Bockg=E5rd?=) In-reply-to: (bojohan@helm.dd.chalmers.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10884 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10884 With this change, does everything work right? It appears to be the right fix for this bug, but I didn't have time to study the whole file carefully. *** regexp-opt.el.~1.21.~ Thu Jun 20 10:43:11 2002 --- regexp-opt.el Sun Jan 19 17:18:58 2003 *************** *** 223,229 **** ;; particular letter and those that do not, and recurse on them. (let* ((char (char-to-string (string-to-char (car strings)))) (half1 (all-completions char strings)) ! (half2 (nthcdr (length half1) strings))) (concat open-group (regexp-opt-group half1) "\\|" (regexp-opt-group half2) --- 223,231 ---- ;; particular letter and those that do not, and recurse on them. (let* ((char (char-to-string (string-to-char (car strings)))) (half1 (all-completions char strings)) ! (half2 strings)) ! (dolist (elt half1) ! (setq half2 (delq elt half2))) (concat open-group (regexp-opt-group half1) "\\|" (regexp-opt-group half2)