From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Updated patch for a Windows implementation of play-sound - 2 Date: Sun, 27 Oct 2002 18:37:50 -0500 Sender: emacs-devel-admin@gnu.org Message-ID: References: <000201c27caa$db78b240$6401a8c0@GODDESS> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1035761978 14176 80.91.224.249 (27 Oct 2002 23:39:38 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 27 Oct 2002 23:39:38 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 185x0L-0003gV-00 for ; Mon, 28 Oct 2002 00:39:37 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 185x4C-0005kz-00 for ; Mon, 28 Oct 2002 00:43:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 185wzz-00076K-00; Sun, 27 Oct 2002 18:39:15 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 185wz7-0006s2-00 for emacs-devel@gnu.org; Sun, 27 Oct 2002 18:38:21 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 185wyc-0006Co-00 for emacs-devel@gnu.org; Sun, 27 Oct 2002 18:38:21 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10) id 185wyc-0006CM-00 for emacs-devel@gnu.org; Sun, 27 Oct 2002 18:37:50 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 185wyc-0000pK-00; Sun, 27 Oct 2002 18:37:50 -0500 Original-To: Bkey1@tampabay.rr.com In-reply-to: <000201c27caa$db78b240$6401a8c0@GODDESS> (Bkey1@tampabay.rr.com) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8836 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8836 > Oh and the "normal" #ifdef style used in Emacs is: > > #if FOO > #else /* !FOO */ > #endif /* !FOO */ Actually our normal style is to write /* not FOO */ rather than /* !FOO */ I find this style of #ifdef blocks to be much too cryptic for my tastes. It is a fine way of saying what command the #endif or #else matches. However, that is all it does. By all means write additional comments to give more information! I find that it is much clearer if your comments for the #else and #endif portions state exactly what #ifdef line they go to What would it mean to "state exactly"? How can you be more explicit than our current convention? I would like to thank you for testing this patch on Linux. Actually he tested it on the GNU/Linux system. Linux alone is just part of a system--you can't run anything on Linux but itself. Would you please call the system "GNU/Linux"? See http://www.gnu.org/gnu/linux-and-gnu.html and http://www.gnu.org/gnu/gnu-linux-faq.html.