all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: monnier+gnu/emacs@rum.cs.yale.edu, emacs-devel@gnu.org
Subject: Re: Updated patch for a Windows implementation of play-sound - 2
Date: Sun, 27 Oct 2002 18:37:50 -0500	[thread overview]
Message-ID: <E185wyc-0000pK-00@fencepost.gnu.org> (raw)
In-Reply-To: <000201c27caa$db78b240$6401a8c0@GODDESS> (Bkey1@tampabay.rr.com)

    >  Oh and the "normal" #ifdef style used in Emacs is:
    >
    >	#if FOO
    >	#else /* !FOO */
    >	#endif /* !FOO */

Actually our normal style is to write /* not FOO */
rather than /* !FOO */

    I find this style of #ifdef blocks to be much too cryptic for my tastes.

It is a fine way of saying what command the #endif or #else matches.
However, that is all it does.  By all means write additional comments
to give more information!

      I find that it is much
    clearer if your comments for the #else and #endif portions state exactly
    what #ifdef line they go to 

What would it mean to "state exactly"?  How can you be more explicit
than our current convention?

    I would like to thank you for testing this patch on Linux.

Actually he tested it on the GNU/Linux system.  Linux alone is just
part of a system--you can't run anything on Linux but itself.
Would you please call the system "GNU/Linux"?

See http://www.gnu.org/gnu/linux-and-gnu.html and
http://www.gnu.org/gnu/gnu-linux-faq.html.

  parent reply	other threads:[~2002-10-27 23:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-25  5:03 Updated patch for a Windows implementation of play-sound - 2 Ben Key
2002-10-25 14:17 ` Stefan Monnier
2002-10-26  4:47   ` Ben Key
2002-10-26 12:39     ` Kai Großjohann
2002-10-27 23:38       ` Richard Stallman
2002-10-27 23:37     ` Richard Stallman [this message]
2002-10-28  1:13       ` Ben Key

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E185wyc-0000pK-00@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier+gnu/emacs@rum.cs.yale.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.