From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: jpw@shootybangbang.com (John Paul Wallington)
Newsgroups: gmane.emacs.devel
Subject: suggested new command `picture-mouse-set-point'
Date: Wed, 23 Oct 2002 19:04:41 +0100
Sender: emacs-devel-admin@gnu.org
Message-ID: <E184Ps1-0006W3-00@bundalo.shootybangbang.com>
NNTP-Posting-Host: main.gmane.org
X-Trace: main.gmane.org 1035396121 2477 80.91.224.249 (23 Oct 2002 18:02:01 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 23 Oct 2002 18:02:01 +0000 (UTC)
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 184PpQ-0000do-00
	for <emacs-devel@main.gmane.org>; Wed, 23 Oct 2002 20:02:00 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 184PrD-00058T-00
	for <emacs-devel@quimby.gnus.org>; Wed, 23 Oct 2002 20:03:51 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 184Pmp-0000CE-00; Wed, 23 Oct 2002 13:59:19 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 184Pm0-00083p-00
	for emacs-devel@gnu.org; Wed, 23 Oct 2002 13:58:28 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 184Plz-00083V-00
	for emacs-devel@gnu.org; Wed, 23 Oct 2002 13:58:28 -0400
Original-Received: from imailg3.svr.pol.co.uk ([195.92.195.181])
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 184Ply-000831-00
	for emacs-devel@gnu.org; Wed, 23 Oct 2002 13:58:26 -0400
Original-Received: from modem-322.stoked.dialup.pol.co.uk ([62.25.189.66] helo=bundalo.shootybangbang.com)
	by imailg3.svr.pol.co.uk with esmtp (Exim 3.35 #1)
	id 184Plu-0005GP-00
	for emacs-devel@gnu.org; Wed, 23 Oct 2002 18:58:23 +0100
Original-Received: from jpw by bundalo.shootybangbang.com with local (Exim 3.32 #1 (Debian))
	id 184Ps1-0006W3-00
	for <emacs-devel@gnu.org>; Wed, 23 Oct 2002 19:04:41 +0100
Original-To: emacs-devel@gnu.org
X-Attribution: jpw
X-Face: R(_z-<e!Z,qjN8xeu/^:Szs}15R'D_9}g7Qlm0x+2sF<`w9o]-oT>rF:grdKO.*u`n);p.i
 $Eiz=h^CO5eDYv"4:K@#\HN09*Ykx}}B{kF/KH}%f_o^Wp<kb`,1KLtZp"^C{-{e~S=IP0_"8B6K+C
 kbKw='FSzftzu
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:8699
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8699

Here is a patch providing a mouse command to set point to the position
clicked on in `picture-mode' making whitespace if necessary, as
suggested by Kai and others.  It seems okay, but isn't great.

Is it worth installing as is?  Can anyone suggest improvements?


--- /build-emacs/emacs/lisp/textmodes/picture.el.~1.40.~	Mon Jul  1 08:47:22 2002
+++ /build-emacs/emacs/lisp/textmodes/picture.el	Wed Oct 23 18:56:22 2002
@@ -1,6 +1,6 @@
 ;;; picture.el --- "Picture mode" -- editing using quarter-plane screen model
 
-;; Copyright (C) 1985, 1994 Free Software Foundation, Inc.
+;; Copyright (C) 1985, 1994, 2002 Free Software Foundation, Inc.
 
 ;; Author: K. Shane Hartman
 ;; Maintainer: FSF
@@ -226,6 +226,18 @@
   (interactive "p")
   (picture-motion (- arg)))
 
+(defun picture-mouse-set-point (event)
+  "Move point to the position clicked on, making whitespace if necessary."
+  (interactive "e")
+  (let* ((pos (posn-col-row (event-start event)))
+	 (x (car pos))
+	 (y (cdr pos))
+	 (current-row (count-lines (window-start) (line-beginning-position))))
+    (unless (equal x (current-column))
+      (picture-forward-column (- x (current-column))))
+    (unless (equal y current-row)
+      (picture-move-down (- y current-row)))))
+
 
 ;; Picture insertion and deletion.
 
@@ -602,6 +614,7 @@
       (picture-substitute 'previous-line 'picture-move-up)
       (picture-substitute 'beginning-of-line 'picture-beginning-of-line)
       (picture-substitute 'end-of-line 'picture-end-of-line)
+      (picture-substitute 'mouse-set-point 'picture-mouse-set-point)
 
       (define-key picture-mode-map "\C-c\C-d" 'delete-char)
       (define-key picture-mode-map "\e\t" 'picture-toggle-tab-state)

-- 
John Paul Wallington