From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [cvs] bug when using pc-selection-mode/transient-mark-mode Date: Mon, 23 Sep 2002 23:24:33 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200209222248.g8MMmKZ26653@rum.cs.yale.edu> <20020923011842.GA29226@gnu.org> Reply-To: rms@gnu.org NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1032838278 7061 127.0.0.1 (24 Sep 2002 03:31:18 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 24 Sep 2002 03:31:18 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu, quarl@hkn.eecs.berkeley.edu, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17tgPt-0001pl-00 for ; Tue, 24 Sep 2002 05:31:17 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17th6T-0003fu-00 for ; Tue, 24 Sep 2002 06:15:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17tgPw-0006OL-00; Mon, 23 Sep 2002 23:31:20 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17tgJQ-0004QV-00 for emacs-devel@gnu.org; Mon, 23 Sep 2002 23:24:36 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17tgJO-0004QJ-00 for emacs-devel@gnu.org; Mon, 23 Sep 2002 23:24:35 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17tgJO-0004QD-00 for emacs-devel@gnu.org; Mon, 23 Sep 2002 23:24:34 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 17tgJN-0006Si-00; Mon, 23 Sep 2002 23:24:33 -0400 Original-To: miles@gnu.org In-reply-to: <20020923011842.GA29226@gnu.org> (message from Miles Bader on Sun, 22 Sep 2002 21:18:42 -0400) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8139 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8139 (1) `mark-active' gets set to a (global) integer counter value instead of t. (2) In the current place where `deactivate-mark' is checked, it just handles the current buffer, but also increments the global counter. (3) `switch-to-buffer' checks to see if `mark-active' is less than the global counter value, and if so, checks the local value of `deactivate-mark' and perhaps sets mark-active to nil. IOW, it lazily does the deactivation based on the local value of deactivate-mark. Is this too expensive a thing to take place in switch-to-buffer? It is not too expensive, I think, but the idea to make deactivate-mark hold a list of buffers is far far simpler and seems better to me. Doesn't that require all the places where deactivate-mark is set to be changed (in a non-trivial way)? Sounds very annoying for programmers... [and a maintainance headache] The places that just bind it to nil to ignore modifications don't need to be changed. The places that set it to nil don't need to be changed. The other references are very few. In the toplevel directory, I found two files that set the variable but really ought to bind it to nil instead; I found two places (delsel.el and simple.el) that set it to t. Nothing else.