From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Date: Tue, 22 Nov 2022 15:19:58 -0800 Message-ID: References: <87wn7o6c9c.fsf@yahoo.com> <701BF611-6506-403E-B70B-2D93F3339E0C@acm.org> <83v8n82yzl.fsf@gnu.org> <83fsec2qq3.fsf@gnu.org> <83edtw2pz3.fsf@gnu.org> <835yf82oc4.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 59426@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 00:21:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxcZr-0003EM-Cy for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 00:21:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxcZc-0006GI-DD; Tue, 22 Nov 2022 18:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxcZa-0006Fk-Fm for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 18:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxcZa-0001K7-7y for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 18:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxcZa-0001v6-44 for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 18:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59426 X-GNU-PR-Package: emacs Original-Received: via spool by 59426-submit@debbugs.gnu.org id=B59426.16691592107218 (code B ref 59426); Tue, 22 Nov 2022 23:21:02 +0000 Original-Received: (at 59426) by debbugs.gnu.org; 22 Nov 2022 23:20:10 +0000 Original-Received: from localhost ([127.0.0.1]:52835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxcYj-0001sL-Ps for submit@debbugs.gnu.org; Tue, 22 Nov 2022 18:20:10 -0500 Original-Received: from mail-pf1-f182.google.com ([209.85.210.182]:36499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxcYh-0001rj-0T for 59426@debbugs.gnu.org; Tue, 22 Nov 2022 18:20:08 -0500 Original-Received: by mail-pf1-f182.google.com with SMTP id x66so7164697pfx.3 for <59426@debbugs.gnu.org>; Tue, 22 Nov 2022 15:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i7V8TsEWiOIAs1/ed2YoDp152n50QU9lSEgoHnGn4Vc=; b=HXIrpnXfy5O1O2oNiNDfGKH1gNpoCZBMCFz25tiBOfybHsEWh7pDSP1HOGYcF3Dgru JGqdTfJpjlVnDXr3kctKBFXsGMmbZa/+CZMrDcnHHf/HeFWCeTrhvi/Tbw2VU7v/5K8I Ju9zOcf42zNIAI0Mw28beqWQe91wm+d66fOu2BQL+gW2U1p7hSOVllsW2nhFpebJ3QMc TsG7NoXB/JgoMbhvh7WywofFNWM+7inTM36aaMIFOo/R6uMjo7Jvtvzr008Usm8YRyHe 2R7RBcVzV/UpSLv7UTV5+IkGAsCczvprrALHwA2O6a/L39d6ExjLXbvZfVB1FdfgOftn R2aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7V8TsEWiOIAs1/ed2YoDp152n50QU9lSEgoHnGn4Vc=; b=Sg4KIvlDfTj4wQWbD+fsmdLK19ApF5y3pAHaOX5rAZY14g1fbEqIbtsxAKNeUK+YgR I5KgUPpOn8JUudka4jltA2e9yq+bc98zhIWS0XcmFRw5hiAokwTmaNJRTNjKmJZOdja6 tG6weHtqqavG/CtZLviOse8herg58kdp+nwd4hGqdsf71V2doHjQXCdAqN7e7Nh3S5/l hNJGxek4RDgoM/XSz0uyZGZwGK4DLAheoVgEzLexjRksFrWGzbDoCeyxKghjP74Tq7PZ m7+YJX63VOU26rEoe3Z273q1q3ZOFueVe2jSPHPHvPFpopoxp0ECWMRLtr8mDQ0HEoCr xkzQ== X-Gm-Message-State: ANoB5plndMHCiL4SbOZBLP3l9jASmEd8hV11Si81mC7y5k0nYUqRUpDW 207a2FX0SR+RPwWr1GzhswQ= X-Google-Smtp-Source: AA0mqf40aY9uwZ3HL/sWYzilLFculoInTpMUkvoZzu2bgrvssYc2vugNgCm4GofOTGFbU9cFC/GlJQ== X-Received: by 2002:a63:fd4c:0:b0:46f:1e8d:d6a8 with SMTP id m12-20020a63fd4c000000b0046f1e8dd6a8mr23866534pgj.248.1669159200906; Tue, 22 Nov 2022 15:20:00 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id s10-20020a170902ea0a00b00186c3727294sm6014710plg.270.2022.11.22.15.19.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 15:20:00 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248689 Archived-At: > On Nov 22, 2022, at 1:08 AM, Mattias Engdeg=C3=A5rd = wrote: >=20 > 21 nov. 2022 kl. 20.00 skrev Yuan Fu : >=20 >> Fortunately tree-sitter doesn=E2=80=99t need a deep stack. I don=E2=80=99= t think any human-written or even machine generated source file is ever = intended to parse into a tree of more than 1k level. Eg, who would = write/generate a function that has thousands level of nested brackets = {{{{{{{{{{{{{{{{=E2=80=A6. ? (Unless they want to try to break the = parser/compiler.) So a sane limit is more than enough, just to guard = against weird source files that makes the parser (erroneously) generate = very very tall trees. >=20 > Thank you, this is good to hear. (Standard minimum limits for = languages such as C are quite low; for example see C99 section 5.2.4.1.) >=20 > What was the reason for the crash that prompted this bug report? Was = it an 'unreasonable' C source file, a grammar mistake (using left = recursion where right recursion should have been used, or vice versa), = or something else? It=E2=80=99s a machine generated file with syntax that tree-sitter-c = can=E2=80=99t handle very well. The file is from bug#45248. >=20 > I hope that tree-sitter does not require a deep stack to handle C = files that are merely very long or has long functions, initialisers etc; = this is common for program-generated source code. Being merely long is no problem: you=E2=80=99ll get a normal-height but = very wide tree. The problem is when the parse tree is very tall. As I = mentioned earlier, I don=E2=80=99t think programming language sources = would produce ~10k levels nesting under normal circumstances. Having 10k = function definitions don=E2=80=99t produce a tall tree, having 10k = nested function definitions do. But who would want a program with 10k = nested functions? Yuan=