From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals Date: Sun, 27 Oct 2024 19:07:41 +0000 Message-ID: References: <874j587459.fsf@poincare.umons.ac.be> <87o739ikze.fsf@poincare.umons.ac.be> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="883"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "73877@debbugs.gnu.org" <73877@debbugs.gnu.org>, Stefan Kangas To: Christophe TROESTLER Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 27 20:08:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t58d4-00004q-Id for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Oct 2024 20:08:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t58co-0001JJ-H0; Sun, 27 Oct 2024 15:08:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t58cl-0001J2-Ov for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 15:08:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t58cl-0004Z5-H4 for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 15:08:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=rHQjPDKkQDxPQtMcVNZeUL1wIwSHSKTiIvVqKBnc/2g=; b=sgOsCLneW41v8G6TdYdxH76cAvS8zCtpz96mx1JLQ/3iQ7xLX8QoUBRLpgLqjBbBueiM9yFoyB3YqbOi29D+7cs5A8vTi7GcRG1z23YQYC3Y+228SJgty1rpTo/EYvpgjfass5ki0/vnTJQ/wxjcKp58mK81JcHKiCd3zSDOIsXH3aPpsyiP+XcJ4tjW9HnWTeWbe+kj0E/GW3Wvlwz58oKdXjL4reMkkpS80yd8fh03r96Wx8n/emrO/ga/PFZilm8JiZpPPYW1u3MmQ3zq5SCjJOOTC8XjIriwUdEBP1gP6+Z+BqOPdH//8TSLAgfQBH9FnVbqQuRJUoSyR9d1eg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t58dK-0005kM-9l for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 15:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2024 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73877-submit@debbugs.gnu.org id=B73877.173005611322038 (code B ref 73877); Sun, 27 Oct 2024 19:09:02 +0000 Original-Received: (at 73877) by debbugs.gnu.org; 27 Oct 2024 19:08:33 +0000 Original-Received: from localhost ([127.0.0.1]:46361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t58cr-0005jO-Gl for submit@debbugs.gnu.org; Sun, 27 Oct 2024 15:08:33 -0400 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:12847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t58cn-0005j4-VA for 73877@debbugs.gnu.org; Sun, 27 Oct 2024 15:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1730056068; x=1730315268; bh=rHQjPDKkQDxPQtMcVNZeUL1wIwSHSKTiIvVqKBnc/2g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Lsx/5v8Fs4YN9U3yT2idLceBrOVLvszCkfsff3QYGDqhFGrNjo70GafGmIG/K9AXq QTXsx1+j+5Kp4IaQbY2fBjGu6wbjeFk4MpqsibCB8PLEGjXbvtieunbkJVO/2bBCmB 5M/kIBXuQJCfHX4/L7NVaYbylrSL3sWmnvXEWmm/z+V+2vhrraQNS/xdNWHt1XQL7Y zhfcaoGZZzEI05lynB1iJyOpE/norsY3Gz/jUJ+0SD3WdFo080bEmb2XH8S0HRJTum fouOSLiYckGsEF3bfGlTQh41/m7t9vSvUmojnX4u5RwUeIIaFJl/mZrVt5HZIMc1in UsIR2XWmJSeMg== In-Reply-To: <87o739ikze.fsf@poincare.umons.ac.be> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 235c1c8ae428f81cdafaaf8f26b0b8abee514d51 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294383 Archived-At: On Thursday, October 24th, 2024 at 11:22, Christophe TROESTLER wrote: >=20 >=20 > Hi, >=20 > Thanks for your comments. Here is an updated patch (against emacs-30, let= me know if you would prefer the emacs-29 branch). >=20 > Best, > C. Thanks Christophe. This should be against the master branch. It will need a commit message (see the CONTRIBUTE file) and a NEWS entry. +(defcustom rust-ts-mode-highlight-number-literal-type nil I'm unsure about this name since it's a little misleading. The type is still highlighted if this is nil, but the same as the number. I don't really have a better suggestion though, and anything else would be longer and probably a little unruly. I was thinking about rust-ts-mode-highlight-number-literal-type-separately but... Maybe we drop the literal part? Does anyone else have any thoughts/suggestions? + :version "30.1" Should be "31.1". For rust-ts-test-font-lock, I'm wondering if we should split that up to a new ert-deftest. If we have more customizations in the future we'd probably end up doing that anyway. Also, I'm not sure we need to bother resetting the rust-ts-mode-highlight-n= umber-literal-type variable.