From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: pabbrev Date: Wed, 14 Feb 2024 23:23:09 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39806"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: phillip.lord@newcastle.ac.uk, emacs-devel@gnu.org To: Terrence Yearwood Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 15 06:31:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raULm-000ADl-Dv for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Feb 2024 06:31:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raULM-0002PD-3U; Thu, 15 Feb 2024 00:31:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raNet-0002vV-QQ for emacs-devel@gnu.org; Wed, 14 Feb 2024 17:23:15 -0500 Original-Received: from mail-vi1eur02olkn2100.outbound.protection.outlook.com ([40.92.48.100] helo=EUR02-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raNer-0004Cx-Rh for emacs-devel@gnu.org; Wed, 14 Feb 2024 17:23:15 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VKBDjQ4ep8Irzgoy5XAvssw2Rj2Gb2aVNQFxeJcSdPbUrWt+kFScwNqZU2nDzd5o2ElChriQGM/E0DQpQuXELKDnCpnevqjuHSDWFSpIQMysAZSqiCy/FeyOPe4UmT/rpJwEsx76W3HtAvMyfSFqO1AVzoLgn03xBWMUsPKM+Wi8xravxnq9lmi1UOAfCMsMahDV+rPa91+30UCBWzeq3pRW4k9Q8NaxPHAYiEXKaOJAYv7lNLb/UG2WzTqlDUlD/ROQ2fhBRN6NHYw6ud116hYsWoEk7rJrvmvGVWnUZsyH3tI2sy6+yZKP+YM7vKA1g7RW7ziNfV2/Xw1J52a2eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oiu/sx897B11K45q0bSOG3c8WJ/6PGINgcolxJTQS8A=; b=Atr6RBc+PS349a+pwIxJ4Cv1CP6KVSF/9ABO1GjbejI74hkaaS60Tud2g24PcDeJjD17NhwYm8Cqqc4DoExbOfljYzYESX9YFA+9bxPxn3XKvWgSNHcYfGqq4x5vcOvsg4WXrJatEy0WKCngjmeEIVHdJI+fJS3jOttlGXZrDRkeEy+FnOPomxktldsVcAMlD/5p298IV3sC6MjxT51rgW/lDv7Mj3AhEo45BzBv7GfDAfbyWhN2AOS0yJ4qvYMJhz4IVux8S3zsjILZbK4RR+uJ9EGA36Emdq4bQOnDhJtt8JiMi3GqLfynSlwPZtNS992/lAd2ZwXoeXt0Mj8+BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oiu/sx897B11K45q0bSOG3c8WJ/6PGINgcolxJTQS8A=; b=Wh4UeKycISIfMG1U5Kl03/eYcIx0KI1Hl/gKVxuv8aIJE2HZzz7t6FZFZ6SFHrFemrfSqku/AUauJho+IeOqo91QEUkKZfmgxqxhn8OkMP2NAOgCrKd12A/dl/B2lxc5Lx9vun7jo+ZUpM48S7Tu38JnR6ZbA2dN736rqZ01XjH4HWjdCM4hihBA6N7TW3mzUbd9rajOGVcThiRsUUXy06qMPkpgcuf+E4mbbJYH/E29zjlJmcwkh8fMsFKCgRKzQydOXGM/H7Tfrt7GTRLKD98qb6SPHp/5l95lwd+ERl0ZwHuQmxS+lHYMhZVeU1nxPBxNHoAzPPg5zARER9aS7Q== Original-Received: from DU2PR02MB10109.eurprd02.prod.outlook.com (2603:10a6:10:497::14) by DU0PR02MB9346.eurprd02.prod.outlook.com (2603:10a6:10:415::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.38; Wed, 14 Feb 2024 22:23:10 +0000 Original-Received: from DU2PR02MB10109.eurprd02.prod.outlook.com ([fe80::1752:9b0:4c48:15f8]) by DU2PR02MB10109.eurprd02.prod.outlook.com ([fe80::1752:9b0:4c48:15f8%7]) with mapi id 15.20.7270.036; Wed, 14 Feb 2024 22:23:10 +0000 In-Reply-To: (Terrence Yearwood's message of "Wed, 14 Feb 2024 15:48:27 -0500") X-TMN: [dpSai6kHK/6k2BWu3AzXXJbsi/12QefuT7m4fqm9j0Q=] X-ClientProxiedBy: MM0P280CA0069.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:8::6) To DU2PR02MB10109.eurprd02.prod.outlook.com (2603:10a6:10:497::14) X-Microsoft-Original-Message-ID: <87h6ia4rea.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR02MB10109:EE_|DU0PR02MB9346:EE_ X-MS-Office365-Filtering-Correlation-Id: bc5fe958-db39-438c-a2bc-08dc2dab86e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OuLQOaDvcTbx5tl18c3ocUSF/kE7Gu5K0NzLBiWbfWtAHoofj+o/C2EqOpAchf6PI/6lZc9syFPvCamuGW4lB55GdlL4THsa+iRL2svCBviTez+Ov8IFKUGeVzP8paLqcNzarlfS27CWWyng28IGl3Nq648XrZy2O5om0XgVx9rOJYBFzb+USe6RW76ZgUZbiIUWW//CcatA4CKyFXQsbER1xCoODk4jk6wZFiIpyGKR6WzpKr2QASSN8ceCnIGQCOdSKVOsXwiP6zj2sP0pW1ZMVw3BIK97jYV+As0R0JvYWuRhcFPMAIvvFiMLJzj/p7SrABfwreY6pJiLxPmayRlA6/QxKAawH9vBW1BB24uCAgcWWGNeo/OEVjRB0NLaXvJbx9aJlklR38Zj9XsB0pDUB6GjBtw0mwZHYgzrStlQW+dN+QharOpwLeF+ZW0p/SKGdG6y5yuHPA4zKiCV2o62bkw8483bu19HX2o+fjWQUXJFR/efl02MpkZ/4NQFtFvwh61pLwH2/1+2eZnRO4Ew5e7H10bX+b530W+dzAIVfFuuUG5IJQdLcqCJXjtZ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXFIYzJJLzBOY2wvSExsSVk2M0RvaGx4RmlNTTAxc1BzY2xPREQzTjNVUXlj?= =?utf-8?B?aXFYU3NraEVjaEVJNHNYT2JHZDUwYW9iOGVaOFFoMFhMRXlrNGJqaGt6Q3Ay?= =?utf-8?B?cFFzbDViNEExcSs1aG5oNy9CRTM3SCtiMWQxd25HNTMyejlOMlI1OUczTGRv?= =?utf-8?B?UUNISWxUWnBsOGdEM25DcXRuc3Y1MXJteCtiMkpaQTFlTS9KbUZqWWtOUXo1?= =?utf-8?B?NTJWVE5UVy80TjExaXdxa2VmK1JZQU51dXVYY1V5NnV3eWFycytrQ1NMcCtF?= =?utf-8?B?TWlSRTJIR3YvUTJOb1dtSVdFSkozYXNKWVk4bW4xUDJCQXhQd1BqeVBsb0Y4?= =?utf-8?B?QUFCRHQ1TS82Vy9PaWwwWHhkWHRUSmhhY2NvVWw3SC9kVHphT0lwMnBLQmFS?= =?utf-8?B?ZVcvNUNKOG5aQkYrNlgzd3NiWG9MWFRXRjIyTjZuZU8wMXZsZ09ndzd0M2JW?= =?utf-8?B?MG8rOFduSWo1U21HTjk0TGdPZ1RFR2tlY0ErQUx4NHc0Q0tHU0xZZmtOZ2c0?= =?utf-8?B?OWR6N2ZpTTVsMXJkenMzOFdUeUlPbTlpYjV2U1A2STV0Vk92V0xoZVFQMUM0?= =?utf-8?B?MW5EaEQ3cVpScm9PZi83aGdsdWg4bk1yZ2k1djNOV25tdDE3T01xQklhOVB2?= =?utf-8?B?V1hLbUdaQ3ZTUzFmcTF1NmJUbU9DVmtyeTBIcm X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-ab7de.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: bc5fe958-db39-438c-a2bc-08dc2dab86e4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR02MB10109.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 22:23:10.8990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB9346 Received-SPF: pass client-ip=40.92.48.100; envelope-from=arthur.miller@live.com; helo=EUR02-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 15 Feb 2024 00:31:26 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316218 Archived-At: Terrence Yearwood writes: Hi Terrence, thank you very much for the bug repport and fix. > Hello, sorry about contacting you directly. > I'm a hobbyist, don't have github account. Github is not a problem. You can send me a patch; it works fine or me. However, you need to sign FSF copyright if you would like to add any signif= icant contribution. However, this one seems like a very small so it is probably n= ot a problem. However, I have attached emacs-devel just to double check. I am a= bit new to maintaining a package myself. > I've been using this essential package for ages! I have just discovered it myself, but I think it is great. Thanks goes to Phillip! > I noticed an anomaly from the time I started using pabbrev. > The following message would pop up when I updated my packages: > > Error running timer =E2=80=98pabbrev-idle-timer-function=E2=80=99: (err= or "Selecting > deleted buffer") > > In October 2023, I decided to fix the problem. > The following is the context for the error: > > (1) pabbrev enabled globally > (2) execute command: package-list-packages > or from the menu: Options -> Manage Emacs Packages I have now tested, but I can't reproduce the bug you are describing. I did = M-x package-list-packages, followed by an U x to update packages, whereas about= 15 packages got upgraded. Pabbrev was not complaining and I do use global pabbrev mode. I uninstalled= my in-house I work on, and have installed one from the Melpa. It can be a diff= erent versions of Emacs perhaps? However, it sounds reasonable to me to check if a buffer is live; so I have= no problems installing your suggestion if it is OK from the copyright perspect= ive. > The following is the modified function: > > (defun pabbrev-idle-timer-function (&optional buffer) > ;; so this only works on the current buffer. Might want to scavenge > ;; over other buffers > (let ((first-live-bufr (seq-find #'buffer-live-p (list buffer > pabbrev-timer-buffer (current-buffer)) nil))) > (when (or first-live-bufr) > (with-current-buffer first-live-bufr > (if (and pabbrev-mode (not pabbrev-disable-timers)) > (pabbrev-idle-timer-function-0) > (pabbrev-debug-message "idle running in non pabbrev-mode")))))) > > > Thx Just a small stylistic remark: (when (or first-live-bufr)) Or is not needed; I guess just a left over from some testing. We can also combine `let' and `when' in one form, so I have rewritten the c= ode to: (defun pabbrev-idle-timer-function (&optional buffer) ;; so this only works on the current buffer. Might want to scavenge ;; over other buffers (when-let ((first-live-bufr (seq-find #'buffer-live-p (list buffer pabbrev-timer-buffer (current-buffer))))) (with-current-buffer first-live-bufr (if (and pabbrev-mode (not pabbrev-disable-timers)) (pabbrev-idle-timer-function-0) (pabbrev-debug-message "idle running in non pabbrev-mode"))))) If someone of emacs maintainers can confirm that 4 lines of code are not requiring FSF copyright aissignement, I'll be happy to install the suggesti= on by Terrence. For the eventual future info: how much is considered as "insignificant" and how do I test if someone has signed FSF papers? It was = about sending email to some addresss? Thank you very much for the help. PS: I have attached Phillip, I think he is happy to hear people are using his package for years. Best regards /arthur